Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf51: uart_1 does not compile #21148

Closed
aep opened this issue Dec 3, 2019 · 3 comments
Closed

nrf51: uart_1 does not compile #21148

aep opened this issue Dec 3, 2019 · 3 comments
Assignees
@anangl
Labels
area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: low Low impact/importance bug

Comments

@aep
Copy link

aep commented Dec 3, 2019 •
edited
Loading

nrf52840_pca10056 doesn't seem to compile with uart1 enabled

i suspect this dts is wrong in boards/arm/nrf52840_pca10056/nrf52840_pca10056.dts

152 arduino_serial: &uart1 {
153   status = "okay";
154   current-speed = <115200>;
155   rx-pin = <33>;
156   tx-pin = <34>;
157 };
158

because uart1 is UARTE

changing it to uarte makes it compile just fine. it still doesnt work at runtime tho (no output), so probably something else missing.

how to reproduce:

enable UART_1_NRF_UARTE

west build -p auto  -b nrf52840_pca10056   samples/subsys/shell/shell_module

[0/1] Re-running CMake...
Zephyr version: 2.1.0
-- Selected BOARD nrf52840_pca10056
-- Found west: /home/aep/.local/bin/west (found suitable version "0.6.0", minimum required is "0.6.0")
-- Loading /home/aep/proj/artanis/os/zephyrproject/zephyr/boards/arm/nrf52840_pca10056/nrf52840_pca10056.dts as base
Devicetree configuration written to /home/aep/proj/artanis/os/zephyrproject/zephyr/build/zephyr/include/generated/generated_dts_board.conf
Parsing Kconfig tree in /home/aep/proj/artanis/os/zephyrproject/zephyr/samples/subsys/shell/shell_module/Kconfig
Loaded configuration '/home/aep/proj/artanis/os/zephyrproject/zephyr/build/zephyr/.config'
No change to '/home/aep/proj/artanis/os/zephyrproject/zephyr/build/zephyr/.config'
-- Cache files will be written to: /home/aep/.cache/zephyr
-- Configuring done
-- Generating done
-- Build files have been written to: /home/aep/proj/artanis/os/zephyrproject/zephyr/build
[126/143] Building C object zephyr/drivers/serial/CMakeFiles/drivers__serial.dir/uart_nrfx_uarte.c.obj
FAILED: zephyr/drivers/serial/CMakeFiles/drivers__serial.dir/uart_nrfx_uarte.c.obj 
ccache /opt/toolchains/gcc-arm-none-eabi-7-2018-q2-update/bin/arm-none-eabi-gcc -DBUILD_VERSION=v2.1.0-rc2-37-g92e017fd70b2 -DKERNEL -DNRF52840_XXAA -D_FORTIFY_SOURCE=2 -D__PROGRAM_START -D__ZEPHYR_SUPERVISOR__ -D__ZEPHYR__=1 -I../include -I../include/drivers -Izephyr/include/generated -I../soc/arm/nordic_nrf/nrf52 -I../ext/lib/fnmatch/. -I../ext/hal/cmsis/Core/Include -I/home/aep/proj/artanis/os/zephyrproject/modules/hal/nordic/nrfx -I/home/aep/proj/artanis/os/zephyrproject/modules/hal/nordic/nrfx/drivers/include -I/home/aep/proj/artanis/os/zephyrproject/modules/hal/nordic/nrfx/mdk -I/home/aep/proj/artanis/os/zephyrproject/modules/hal/nordic/. -I/home/aep/proj/artanis/os/zephyrproject/modules/debug/segger/rtt -isystem ../lib/libc/minimal/include -isystem /opt/toolchains/gcc-arm-none-eabi-7-2018-q2-update/bin/../lib/gcc/arm-none-eabi/7.3.1/include -isystem /opt/toolchains/gcc-arm-none-eabi-7-2018-q2-update/bin/../lib/gcc/arm-none-eabi/7.3.1/include-fixed -Os -imacros/home/aep/proj/artanis/os/zephyrproject/zephyr/build/zephyr/include/generated/autoconf.h -ffreestanding -fno-common -g -mthumb -mcpu=cortex-m4 -imacros/home/aep/proj/artanis/os/zephyrproject/zephyr/include/toolchain/zephyr_stdint.h -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-main -Wno-pointer-sign -Wpointer-arith -Wno-unused-but-set-variable -Werror=implicit-int -fno-asynchronous-unwind-tables -fno-pie -fno-pic -fno-strict-overflow -fno-reorder-functions -fno-defer-pop -ffunction-sections -fdata-sections -mabi=aapcs -march=armv7e-m -std=c99 -nostdinc -MD -MT zephyr/drivers/serial/CMakeFiles/drivers__serial.dir/uart_nrfx_uarte.c.obj -MF zephyr/drivers/serial/CMakeFiles/drivers__serial.dir/uart_nrfx_uarte.c.obj.d -o zephyr/drivers/serial/CMakeFiles/drivers__serial.dir/uart_nrfx_uarte.c.obj   -c /home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1386:15: error: 'DT_NORDIC_NRF_UARTE_UART_1_CURRENT_SPEED' undeclared here (not in a function); did you mean 'DT_NORDIC_NRF_UART_UART_1_CURRENT_SPEED'?
   .baudrate = DT_NORDIC_NRF_UARTE_UART_##idx##_CURRENT_SPEED,    \
               ^
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1328:3: note: in expansion of macro 'UARTE_CONFIG'
   UARTE_CONFIG(idx),            \
   ^~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1440:2: note: in expansion of macro 'UART_NRF_UARTE_DEVICE'
  UART_NRF_UARTE_DEVICE(1);
  ^~~~~~~~~~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1338:4: error: 'DT_NORDIC_NRF_UARTE_UART_1_BASE_ADDRESS' undeclared here (not in a function); did you mean 'DT_NORDIC_NRF_UART_UART_1_BASE_ADDRESS'?
    DT_NORDIC_NRF_UARTE_UART_##idx##_BASE_ADDRESS,        \
    ^
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1440:2: note: in expansion of macro 'UART_NRF_UARTE_DEVICE'
  UART_NRF_UARTE_DEVICE(1);
  ^~~~~~~~~~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c: In function 'uarte_1_init':
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1349:15: error: 'DT_NORDIC_NRF_UARTE_UART_1_TX_PIN' undeclared (first use in this function); did you mean 'DT_NORDIC_NRF_UART_UART_1_TX_PIN'?
    .pseltxd = DT_NORDIC_NRF_UARTE_UART_##idx##_TX_PIN,    \
               ^
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1440:2: note: in expansion of macro 'UART_NRF_UARTE_DEVICE'
  UART_NRF_UARTE_DEVICE(1);
  ^~~~~~~~~~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1349:15: note: each undeclared identifier is reported only once for each function it appears in
    .pseltxd = DT_NORDIC_NRF_UARTE_UART_##idx##_TX_PIN,    \
               ^
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1440:2: note: in expansion of macro 'UART_NRF_UARTE_DEVICE'
  UART_NRF_UARTE_DEVICE(1);
  ^~~~~~~~~~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1350:15: error: 'DT_NORDIC_NRF_UARTE_UART_1_RX_PIN' undeclared (first use in this function); did you mean 'DT_NORDIC_NRF_UARTE_UART_1_TX_PIN'?
    .pselrxd = DT_NORDIC_NRF_UARTE_UART_##idx##_RX_PIN,    \
               ^
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1440:2: note: in expansion of macro 'UART_NRF_UARTE_DEVICE'
  UART_NRF_UARTE_DEVICE(1);
  ^~~~~~~~~~~~~~~~~~~~~
In file included from ../include/sched_priq.h:9:0,
                 from ../include/kernel_includes.h:23,
                 from ../include/kernel.h:17,
                 from ../include/device.h:11,
                 from ../include/drivers/uart.h:26,
                 from /home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:11:
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1356:5: error: 'DT_NORDIC_NRF_UARTE_UART_1_IRQ_0_PRIORITY' undeclared (first use in this function); did you mean 'DT_NORDIC_NRF_UART_UART_1_IRQ_0_PRIORITY'?
     DT_NORDIC_NRF_UARTE_UART_##idx##_IRQ_0_PRIORITY, \
     ^
../include/sys/util.h:347:26: note: in definition of macro '__DEBRACKET'
 #define __DEBRACKET(...) __VA_ARGS__
                          ^~~~~~~~~~~
../include/sys/util.h:344:2: note: in expansion of macro '__GET_ARG2_DEBRACKET'
  __GET_ARG2_DEBRACKET(one_or_two_args _if_code, _else_code)
  ^~~~~~~~~~~~~~~~~~~~
../include/sys/util.h:321:2: note: in expansion of macro '__COND_CODE'
  __COND_CODE(_XXXX##_flag, _if_1_code, _else_code)
  ^~~~~~~~~~~
../include/sys/util.h:318:2: note: in expansion of macro 'Z_COND_CODE_1'
  Z_COND_CODE_1(_flag, _if_1_code, _else_code)
  ^~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1353:3: note: in expansion of macro 'COND_CODE_1'
   COND_CODE_1(IS_ENABLED(CONFIG_UART_##idx##_INTERRUPT_DRIVEN),  \
   ^~~~~~~~~~~
../include/irq.h:51:2: note: in expansion of macro 'ARCH_IRQ_CONNECT'
  ARCH_IRQ_CONNECT(irq_p, priority_p, isr_p, isr_param_p, flags_p)
  ^~~~~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1354:5: note: in expansion of macro 'IRQ_CONNECT'
    (IRQ_CONNECT(            \
     ^~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1440:2: note: in expansion of macro 'UART_NRF_UARTE_DEVICE'
  UART_NRF_UARTE_DEVICE(1);
  ^~~~~~~~~~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1360:15: error: 'DT_NORDIC_NRF_UARTE_UART_1_IRQ_0' undeclared (first use in this function); did you mean 'DT_NORDIC_NRF_UART_UART_1_IRQ_0'?
    irq_enable(DT_NORDIC_NRF_UARTE_UART_##idx##_IRQ_0);), ())\
               ^
../include/sys/util.h:347:26: note: in definition of macro '__DEBRACKET'
 #define __DEBRACKET(...) __VA_ARGS__
                          ^~~~~~~~~~~
../include/sys/util.h:344:2: note: in expansion of macro '__GET_ARG2_DEBRACKET'
  __GET_ARG2_DEBRACKET(one_or_two_args _if_code, _else_code)
  ^~~~~~~~~~~~~~~~~~~~
../include/sys/util.h:321:2: note: in expansion of macro '__COND_CODE'
  __COND_CODE(_XXXX##_flag, _if_1_code, _else_code)
  ^~~~~~~~~~~
../include/sys/util.h:318:2: note: in expansion of macro 'Z_COND_CODE_1'
  Z_COND_CODE_1(_flag, _if_1_code, _else_code)
  ^~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1353:3: note: in expansion of macro 'COND_CODE_1'
   COND_CODE_1(IS_ENABLED(CONFIG_UART_##idx##_INTERRUPT_DRIVEN),  \
   ^~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1360:4: note: in expansion of macro 'irq_enable'
    irq_enable(DT_NORDIC_NRF_UARTE_UART_##idx##_IRQ_0);), ())\
    ^~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1440:2: note: in expansion of macro 'UART_NRF_UARTE_DEVICE'
  UART_NRF_UARTE_DEVICE(1);
  ^~~~~~~~~~~~~~~~~~~~~
In file included from ../include/drivers/uart.h:26:0,
                 from /home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:11:
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c: At top level:
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1375:9: error: 'DT_NORDIC_NRF_UARTE_UART_1_LABEL' undeclared here (not in a function); did you mean 'DT_NORDIC_NRF_UART_UART_1_LABEL'?
         DT_NORDIC_NRF_UARTE_UART_##idx##_LABEL,         \
         ^
../include/device.h:107:11: note: in definition of macro 'DEVICE_AND_API_INIT'
   .name = drv_name, .init = (init_fn),     \
           ^~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1374:2: note: in expansion of macro 'DEVICE_DEFINE'
  DEVICE_DEFINE(uart_nrfx_uarte##idx,           \
  ^~~~~~~~~~~~~
/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1440:2: note: in expansion of macro 'UART_NRF_UARTE_DEVICE'
  UART_NRF_UARTE_DEVICE(1);
  ^~~~~~~~~~~~~~~~~~~~~
[135/143] Building C object zephyr/kernel/CMakeFiles/kernel.dir/timer.c.obj
ninja: build stopped: subcommand failed.
FATAL ERROR: cannot run flash; no --build-dir given and build in current directory /home/aep/proj/artanis/os/zephyrproject/zephyr/build failed
@aep aep added the bug The issue is a bug, or the PR is fixing a bug label Dec 3, 2019
@galak galak added area: UART Universal Asynchronous Receiver-Transmitter platform: nRF Nordic nRFx labels Dec 3, 2019
@dleach02 dleach02 added the priority: low Low impact/importance bug label Dec 3, 2019
@anangl
Copy link
Member

anangl commented Dec 4, 2019

@aep
I cannot reproduce this. The sample (samples/subsys/shell/shell_module) builds fine for me with UART_1 enabled (I set CONFIG_UART_1_NRF_UARTE=y in this sample's prj.conf).

But looking at the console output you provided, I don't entirely get one thing (I divided the original line into three for better visibility):

/home/aep/proj/artanis/os/zephyrproject/zephyr/drivers/serial/uart_nrfx_uarte.c:1386:15:
error: 'DT_NORDIC_NRF_UARTE_UART_1_CURRENT_SPEED' undeclared here (not in a function);
did you mean 'DT_NORDIC_NRF_UART_UART_1_CURRENT_SPEED'?

Have you changed the compatible property in the uart1 node to "nordic,nrf-uart"?
It should be "nordic,nrf-uarte" as originally set in nrf52840.dtsi. Then, the macro would be generated with the name DT_NORDIC_NRF_UARTE_UART_1_CURRENT_SPEED, as expected by the driver.

And what do you mean by:

i suspect this dts is wrong in boards/arm/nrf52840_pca10056/nrf52840_pca10056.dts
[..]
because uart1 is UARTE

changing it to uarte makes it compile just fine.

What are you actually changing? There's no need to correct anything here. As I wrote above, the compatible property for the uart1 node should be set to "nordic,nrf-uarte", and it is so by default.

@aep
Copy link
Author

aep commented Dec 4, 2019 •
edited
Loading

well,... embarrassing. Apparently i broke this. it works fine with a fresh clone and going through my own repro steps. sorry :/

i think i got confused by the &arduino_serial node in the board dts, but looking at nrf52840.dtsi as you said, it makes sense now

@aep aep closed this as completed Dec 4, 2019
@anangl
Copy link
Member

anangl commented Dec 4, 2019

well,... embarrassing. Apparently i broke this. it works fine with a fresh clone and going through my own repro steps. sorry :/

No worries. It happens. Good that we managed to solve this quickly and now it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anangl anangl

Labels
area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aep @galak @anangl @dleach02