Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitycheck fails to merge OVERLAY_CONFIG properly #22258

Closed
mniestroj opened this issue Jan 28, 2020 · 1 comment
Closed

sanitycheck fails to merge OVERLAY_CONFIG properly #22258

mniestroj opened this issue Jan 28, 2020 · 1 comment
Assignees
Labels
area: Sanitycheck Sanitycheck has been renamed to Twister bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@mniestroj
Copy link
Member

mniestroj commented Jan 28, 2020

Describe the bug
Sanitycheck fails to merge OVERLAY_CONF properly before passing this argument to build system.

To Reproduce
Steps to reproduce the behavior:

  1. ./scripts/sanitycheck -p qemu_x86 -T samples/net/sockets/echo_client/ -i
  2. Look at ./sanity-out/qemu_x86/samples/net/sockets/echo_client/sample.net.sockets.echo_client.bt/build.log
  3. Look at merged configuration, there is no overlay-bt.conf that should be mentioned there:
Loaded configuration '/zephyr/boards/x86/qemu_x86/qemu_x86_defconfig'
Merged configuration '/zephyr/samples/net/sockets/echo_client/prj.conf'
Merged configuration '/zephyr/samples/net/sockets/echo_client/boards/qemu_x86.conf'
Configuration saved to '/zephyr/sanity-out/qemu_x86/samples/net/sockets/echo_client/sample.net.sockets.echo_client.bt/zephyr/.config'

Expected behavior
overlay-bt.conf should be taken into account:

Merged configuration 'overlay-bt.conf'

Impact
Sanitycheck doesn't properly test all configurations within the project, because it fails to merge OVERLAY_CONF options together.

Environment (please complete the following information):

  • OS: Linux
  • Toolchain: Zephyr SDK
  • Commit SHA or Version used: c793c0e
@mniestroj mniestroj added the bug The issue is a bug, or the PR is fixing a bug label Jan 28, 2020
@aescolar aescolar added the area: Sanitycheck Sanitycheck has been renamed to Twister label Jan 28, 2020
@jhedberg jhedberg added the priority: low Low impact/importance bug label Jan 28, 2020
@nashif
Copy link
Member

nashif commented Feb 6, 2020

should be fixed

@nashif nashif closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sanitycheck Sanitycheck has been renamed to Twister bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants