[Coverity CID :208202] Arguments in wrong order in samples/subsys/canbus/isotp/src/main.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/e089906b339aad4cd1b6589a3b6ce94782d93f54/samples/subsys/canbus/isotp/src/main.c#L112

Category: API usage errors
Function: rx_0_5_thread
Component: Samples
CID: 208202

Details:

106         ARG_UNUSED(arg1);
107         ARG_UNUSED(arg2);
108         ARG_UNUSED(arg3);
109         int ret, received_len;
110         static u8_t rx_buffer[32];
111    
>>>     CID 208202:  API usage errors  (SWAPPED_ARGUMENTS)
>>>     The positions of arguments in the call to "isotp_bind" do not match the ordering of the parameters:
112         ret = isotp_bind(&recv_ctx_0_5, can_dev,
113                  &tx_addr_0_5, &rx_addr_0_5,
114                  &fc_opts_0_5, K_FOREVER);
115         if (ret != ISOTP_N_OK) {
116             printk("Failed to bind to rx ID %d [%d]\n",
117                    rx_addr_0_5.std_id, ret);

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[alexanderwachter]

Intentional. We have receiver and sender on the same node, so we need to switch the addresses somewhere.