Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

si7006 temperature conversion offset missing #22907

Closed
anthonybrandon opened this issue Feb 18, 2020 · 4 comments
Closed

si7006 temperature conversion offset missing #22907

anthonybrandon opened this issue Feb 18, 2020 · 4 comments
Assignees
@MaureenHelm
Labels
area: Sensors Sensors bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@anthonybrandon
Copy link
Contributor

The si7006 sensor driver (./drivers/sensor/si7006/si7006.c) is missing an offset as described in the datasheet. An offset of 46.85 should be subtracted in order to get the temperature in degrees Celsius.

#19941 attempts to fix it along with some unrelated changes.
@anthonybrandon anthonybrandon added the bug The issue is a bug, or the PR is fixing a bug label Feb 18, 2020
@carlescufi
Copy link
Member

@anthonybrandon would you mind reviewing and testing #19941 to see if we can move it forward?

@carlescufi carlescufi added the area: Sensors Sensors label Feb 18, 2020
@MaureenHelm MaureenHelm added the priority: low Low impact/importance bug label Feb 18, 2020
@anthonybrandon
Copy link
Contributor Author

@carlescufi

Sure, I have a board I can try it out on.
Do I just report it in a comment on the merge request once I have tried it, or did you mean something else?

@carlescufi
Copy link
Member

@carlescufi

Sure, I have a board I can try it out on.
Do I just report it in a comment on the merge request once I have tried it, or did you mean something else?

Yep, just approve the Pull Request and add a comment there.

@forGGe forGGe mentioned this issue Feb 24, 2020
Closed
@MaureenHelm
Copy link
Member

Fixed by #24563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaureenHelm MaureenHelm

Labels
area: Sensors Sensors bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SI7006 sensor: combined RH/T measurements and fixed temperature conversion forGGe/zephyr
3 participants
@MaureenHelm @carlescufi @anthonybrandon