-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hal_infineon: Add new module for Infineon XMC HAL layer #24554
Comments
The license looks good to me, what is the source of the library @parthitce? Did you download it from an SDK? |
@carlescufi Yes, it's downloaded from infineon Dave SDK. Downloaded from: http://dave.infineon.com/Libraries/XMCLib/XMC_Peripheral_Library_v2.1.24.zip #copied the below statement from here |
Thanks, could you add any |
@carlescufi The Lincense file is included here: https://github.com/linumiz/hal_infineon/blob/master/XMCLib/drivers/License.txt Should I move to the parent directory of hal_infineon instead? |
If it applies to the whole of the contents, including the |
Yes, device specific implementation also belongs to the same SDK. I will move the License to parent directory. Thanks. |
You threw me with this comment. We don't have any 4-clause BSD yet, so that would trigger the license approval process. However, the text actually looks like 3-clause BSD to me. |
It is 3-clause BSD license. The styling in the file headers is unusual and that made it look like "4-clause": |
I moved the License file to the parent directory here: https://github.com/linumiz/hal_infineon/blob/master/License.txt. Thanks Yes, this is 3-Clause BSD License (same as this). |
@parthitce before we create this repo, can you confirm that you will maintain this platform? |
Sorry for the noise! |
@carlescufi Yes, I confirm that I will maintain this platform. Thanks. |
@carlescufi Ping on this module creation. |
@parthitce sorry for the delay, I've been busy with the release. I should be able to create it tomorrow. |
@parthitce could you please point us to the hardware documentation for this hardware for the record, so we know we can fix issues by looking at a datasheet or reference manual? |
@carlescufi Current zephyr PR (#24555) is based on xmc4500 SoC alone, but this should be same for all the XMC4xxx series. TRM XMC4500: https://www.infineon.com/dgdl/Infineon-xmc4500_rm_v1.6_2016-UM-v01_06-EN.pdf?fileId=db3a30433580b3710135a5f8b7bc6d13 TRM and Datasheet for all the XMC series is available online. |
@parthitce thank you for your patience. That said, please make sure that you format the commit similarly to this one: |
@carlescufi Thanks, I will re-format the commit message and will push it. |
#24555 is merged. Closing this issue. |
Introduction
Support for infineon XMC series ARM cortex M controllers needs/depends on XMCLib. New HAL module needs to be created to address the dependency.
Problem description
I am submitting the patch to add support for infineon xmc4500 SoC in PR. This PR needs HAL layer for Infineon XMCLib.
Proposed change
hal_infineon is currently pushed with needed adaptation for Zephyr here: https://github.com/linumiz/hal_infineon
This enables the HAL support for all XMC series SoC's from Infineon
Detailed RFC
HAL layer can reviewed from here: https://github.com/linumiz/hal_infineon
Proposed change (Detailed)
NA
Dependencies
NA
Concerns and Unresolved Questions
NA
Alternatives
NA
The text was updated successfully, but these errors were encountered: