Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal_infineon: Add new module for Infineon XMC HAL layer #24554

Closed
parthitce opened this issue Apr 21, 2020 · 20 comments
Closed

hal_infineon: Add new module for Infineon XMC HAL layer #24554

parthitce opened this issue Apr 21, 2020 · 20 comments
Labels
area: Modules RFC Request For Comments: want input from the community
Milestone

Comments

@parthitce
Copy link
Member

Introduction

Support for infineon XMC series ARM cortex M controllers needs/depends on XMCLib. New HAL module needs to be created to address the dependency.

Problem description

I am submitting the patch to add support for infineon xmc4500 SoC in PR. This PR needs HAL layer for Infineon XMCLib.

Proposed change

hal_infineon is currently pushed with needed adaptation for Zephyr here: https://github.com/linumiz/hal_infineon

This enables the HAL support for all XMC series SoC's from Infineon

Detailed RFC

HAL layer can reviewed from here: https://github.com/linumiz/hal_infineon

Proposed change (Detailed)

NA

Dependencies

NA

Concerns and Unresolved Questions

NA

Alternatives

NA

@parthitce parthitce added the RFC Request For Comments: want input from the community label Apr 21, 2020
@parthitce
Copy link
Member Author

@carlescufi @nashif

@carlescufi
Copy link
Member

The license looks good to me, what is the source of the library @parthitce? Did you download it from an SDK?
@nashif @MaureenHelm @galak any objections? License looks like standard 4-clause BSD to me:
https://github.com/linumiz/hal_infineon/blob/master/XMCLib/drivers/src/xmc4_rtc.c#L12

@parthitce
Copy link
Member Author

parthitce commented Apr 21, 2020

The license looks good to me, what is the source of the library @parthitce? Did you download it from an SDK?

@carlescufi Yes, it's downloaded from infineon Dave SDK.

Downloaded from: http://dave.infineon.com/Libraries/XMCLib/XMC_Peripheral_Library_v2.1.24.zip

#copied the below statement from here
DAVE™ (Version 4) – professional free-of-charge integrated development environment (IDE) supporting the whole development process from evaluation-to-production (E2P).

@carlescufi
Copy link
Member

@carlescufi Yes, it's downloaded from infineon Dave SDK.

Thanks, could you add any LICENSE files the .zip file comes with to your module repo?

@parthitce
Copy link
Member Author

@carlescufi Yes, it's downloaded from infineon Dave SDK.

Thanks, could you add any LICENSE files the .zip file comes with to your module repo?

@carlescufi The Lincense file is included here: https://github.com/linumiz/hal_infineon/blob/master/XMCLib/drivers/License.txt

Should I move to the parent directory of hal_infineon instead?

@carlescufi
Copy link
Member

Should I move to the parent directory of hal_infineon instead?

If it applies to the whole of the contents, including the devices/ folder, then yes please.

@parthitce
Copy link
Member Author

Should I move to the parent directory of hal_infineon instead?

If it applies to the whole of the contents, including the devices/ folder, then yes please.

Yes, device specific implementation also belongs to the same SDK. I will move the License to parent directory. Thanks.

@MaureenHelm
Copy link
Member

License looks like standard 4-clause BSD to me

You threw me with this comment. We don't have any 4-clause BSD yet, so that would trigger the license approval process. However, the text actually looks like 3-clause BSD to me.

@stephanosio
Copy link
Member

It is 3-clause BSD license.

The styling in the file headers is unusual and that made it look like "4-clause":
https://github.com/linumiz/hal_infineon/blob/3a27cf18351b2891afbda34ce4a7f528cd12c4d2/XMCLib/drivers/src/xmc1_eru.c#L1-L34

@parthitce
Copy link
Member Author

I moved the License file to the parent directory here: https://github.com/linumiz/hal_infineon/blob/master/License.txt. Thanks

Yes, this is 3-Clause BSD License (same as this).

@carlescufi
Copy link
Member

@parthitce before we create this repo, can you confirm that you will maintain this platform?

@carlescufi
Copy link
Member

License looks like standard 4-clause BSD to me

You threw me with this comment. We don't have any 4-clause BSD yet, so that would trigger the license approval process. However, the text actually looks like 3-clause BSD to me.

Sorry for the noise!

@parthitce
Copy link
Member Author

@parthitce before we create this repo, can you confirm that you will maintain this platform?

@carlescufi Yes, I confirm that I will maintain this platform. Thanks.

@parthitce
Copy link
Member Author

@carlescufi Ping on this module creation.

@carlescufi
Copy link
Member

@parthitce sorry for the delay, I've been busy with the release. I should be able to create it tomorrow.

@carlescufi
Copy link
Member

@parthitce could you please point us to the hardware documentation for this hardware for the record, so we know we can fix issues by looking at a datasheet or reference manual?

@parthitce
Copy link
Member Author

@parthitce could you please point us to the hardware documentation for this hardware for the record, so we know we can fix issues by looking at a datasheet or reference manual?

@carlescufi Current zephyr PR (#24555) is based on xmc4500 SoC alone, but this should be same for all the XMC4xxx series.

TRM XMC4500: https://www.infineon.com/dgdl/Infineon-xmc4500_rm_v1.6_2016-UM-v01_06-EN.pdf?fileId=db3a30433580b3710135a5f8b7bc6d13
Datasheet: https://www.infineon.com/dgdl/Infineon-XMC4500-DS-v01_05-EN.pdf?fileId=5546d46254e133b40154e1b56cbe0123

TRM and Datasheet for all the XMC series is available online.

Overview: https://www.infineon.com/cms/en/product/microcontroller/32-bit-industrial-microcontroller-based-on-arm-cortex-m/#

@carlescufi carlescufi modified the milestones: v2.2.1, v2.3.0 May 7, 2020
@carlescufi
Copy link
Member

@parthitce thank you for your patience.
Please push an initial version to:
https://github.com/zephyrproject-rtos/hal_infineon

That said, please make sure that you format the commit similarly to this one:
zephyrproject-rtos/cmsis@0d43487

@parthitce
Copy link
Member Author

@parthitce thank you for your patience.
Please push an initial version to:
https://github.com/zephyrproject-rtos/hal_infineon

That said, please make sure that you format the commit similarly to this one:
zephyrproject-rtos/cmsis@0d43487

@carlescufi Thanks, I will re-format the commit message and will push it.

@parthitce
Copy link
Member Author

#24555 is merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Modules RFC Request For Comments: want input from the community
Projects
None yet
Development

No branches or pull requests

5 participants