Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpatch.pl doesn't match the vendor string properly #25012

Closed
alexandru-porosanu-nxp opened this issue May 6, 2020 · 2 comments · Fixed by #24959
Closed

checkpatch.pl doesn't match the vendor string properly #25012

alexandru-porosanu-nxp opened this issue May 6, 2020 · 2 comments · Fixed by #24959
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@alexandru-porosanu-nxp
Copy link
Collaborator

alexandru-porosanu-nxp commented May 6, 2020

Describe the bug
checkpatch.pl will complain that the vendor string is not documented, although this is not the case
Due to the slight difference between the vendor-prefixes.yaml from Linux and vendor-prefix

To Reproduce
Steps to reproduce the behavior:

  1. ./scripts/checkpatch.pl -f ./dts/arm/nxp/nxp_kw41z.dtsi
  2. Notice the WARNING:UNDOCUMENTED_DT_STRING: warnings for all the vendors that are in the specific checked file.
    But looking into the vendor-prefixes.txt file, you can see both ARM as well as NXP

Expected behavior
No warning reported

Impact
Annoyance

Screenshots or console output

dts/arm/nxp/nxp_kw41z.dtsi:40: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string vendor "arm" appears un-documented -- check ./dts/bindings/vendor-prefixes.txt
#40: FILE: dts/arm/nxp/nxp_kw41z.dtsi:40:
+			compatible = "arm,cortex-m0+";

dts/arm/nxp/nxp_kw41z.dtsi:52: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nxp,kw41z-mcg" appears un-documented -- check ./dts/bindings/
#52: FILE: dts/arm/nxp/nxp_kw41z.dtsi:52:
+			compatible = "nxp,kw41z-mcg";

dts/arm/nxp/nxp_kw41z.dtsi:52: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string vendor "nxp" appears un-documented -- check ./dts/bindings/vendor-prefixes.txt
...

Environment (please complete the following information):

  • OS: Ubuntu 18.04 LTS
  • Toolchain: Zephyr SDK
  • Commit SHA: 2d9baf9

Additional context
This issue seems to stem from the different format for vendor-prefixes.txt in Zephyr versus vendor-prefixes.yaml in Linux. The commit 5b10fac inadvertently replaces the check with the one from Linux.

@alexandru-porosanu-nxp alexandru-porosanu-nxp added the bug The issue is a bug, or the PR is fixing a bug label May 6, 2020
@stephanosio
Copy link
Member

stephanosio commented May 6, 2020

There is already a PR that fixes this:
#24959

@alexandru-porosanu-nxp
Copy link
Collaborator Author

There is already a PR that fixes this:
#24959

Right, I missed that. I'll close this one (and the corresponding PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants