Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OT: utilsFlashWrite does not take into account the write-block-size #5943

Closed
jfischer-no opened this issue Feb 1, 2018 · 7 comments
Closed
Assignees
Labels
area: OpenThread Enhancement Changes/Updates/Additions to existing features priority: medium Medium impact/importance bug

Comments

@jfischer-no
Copy link
Collaborator

OpenThread utilsFlashWrite does not take into account the write-block-size. OT uses a multiple of 4 while writing to the flash. This leads to a bus fault on a platform like K64F where write-block-size is 8.

Is it possible to abstract utilsFlash* over a file system like nffs?

@jfischer-no jfischer-no added the bug The issue is a bug, or the PR is fixing a bug label Feb 1, 2018
@galak galak added this to the v1.11.0 milestone Feb 1, 2018
@KaSroka
Copy link
Collaborator

KaSroka commented Feb 2, 2018

File abstraction can be used to emulate flash for OpenThread - as example you can see posix OpenThread platform: https://github.com/openthread/openthread/blob/master/examples/platforms/posix/flash.c

We can also write our own settings module that uses file directly instead of flash: https://github.com/openthread/openthread/blob/master/examples/platforms/utils/settings.cpp

@carlescufi
Copy link
Member

@jfischer-phytec-iot Sounds to me like we could write an abstraction over FCB or NFFS. Any takers to implement this in the 1.11 timeline?

@nashif nashif added the priority: medium Medium impact/importance bug label Feb 6, 2018
@carlescufi
Copy link
Member

@jfischer-phytec-iot are you going to give this a go?

@jfischer-no
Copy link
Collaborator Author

@carlescufi I do not know if I can find time for this issue before EW2018.

@nashif nashif modified the milestones: v1.11.0, v1.12.0 Feb 20, 2018
@nashif
Copy link
Member

nashif commented May 15, 2018

any update on this?

@nashif nashif added Enhancement Changes/Updates/Additions to existing features and removed bug The issue is a bug, or the PR is fixing a bug labels May 29, 2018
@nashif nashif removed this from the v1.12.0 milestone Jun 5, 2018
@rlubos rlubos self-assigned this Feb 25, 2019
@rlubos
Copy link
Contributor

rlubos commented Feb 25, 2019

I'll look into this issue. We need a better way to store OpenThread settings - it became an recurring problem recently (#12944, #13687).

@rlubos
Copy link
Contributor

rlubos commented Jan 17, 2020

No longer an issue with #21796.

@rlubos rlubos closed this as completed Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: OpenThread Enhancement Changes/Updates/Additions to existing features priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

6 participants