generated syscall header files don't have ifndef protection

[galak]

For example:

'include/generated/syscalls/rtc.h'

Doesn't have anything like:

#ifndef SYSCALL_RTC_H
#define SYSCALL_RTC_H

....

#endif /* SYSCALL_RTC_H */

[andrewboie]

I'm not seeing a need to change this, what problem would this solve?

These generated headers should never be included directly by anyone, they really need to only be included at the very end of the corresponding headers that define the system calls, inside that header's ifdef guard.

You'll never be able to make these generated headers safe to include in a general sense as they also do not include the necessary headers to pull in data structure definitions used by the system calls.

[galak]

I think doing this might avoid some weird error that might be hard to track down later. The system calls have introduced some interesting include path issues (see commit 8777ff1). So thinking having the headers have proper ifndef protection would just be good form.

[nashif]

we do not have these headers anym,ore