Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on v1.7.3 ? linked component does not load. #72

Open
ovaxio opened this issue Dec 23, 2022 · 0 comments
Open

Bug on v1.7.3 ? linked component does not load. #72

ovaxio opened this issue Dec 23, 2022 · 0 comments
Assignees

Comments

@ovaxio
Copy link

ovaxio commented Dec 23, 2022

storybook v6.5.15
storybook-zeplin v1.7.3

Steps to reproduce

create a MDX story and define the zeplinLink parameter on the component or component

<Meta
  title="Components/Button"
  component={Button}
  parameters={{
    zeplinLink: "zpl://components?pid=...&coids=..."
  }}
/>

Tested also with JSX story without success.

Current behavior

There is no connected component for this story. printed in the panel

Expected behavior

showing the linked component from Zeplin in the Panel

Some Digging

I checked the source code of storybook-zeplin plugin and found that the useLink hook has the storyId as useEffect dependency and was changed from zeplinLink in v1.7.2 in this commit

I change the version to v1.7.2 and now the expected behavior works fine.

@yuqu yuqu self-assigned this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants