You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
@joeirimpan what are your thoughts on having the Order modification/cancellation APIs as methods on the structs themselves instead of the KiteConnect client?
I had similar thoughts. Instead of client.place_order, we could write something like client.order.place? But this will make it inconsistent with other libs that we have in place.
@joeirimpan I was thinking the APIs to fetch/place orders could be offered by the client but, the APIs to modify/cancel the orders themselves could be methods on the Order struct. So we could write something like below
let order = client.place_order();
order.cancel();
Although, as you said this doesn't make much sense if it's inconsistent with the other libraries
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
No description provided.
The text was updated successfully, but these errors were encountered: