Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sodium_init() return value #1635

Closed
ismail opened this issue Nov 5, 2015 · 2 comments
Closed

Handle sodium_init() return value #1635

ismail opened this issue Nov 5, 2015 · 2 comments

Comments

@ismail
Copy link

ismail commented Nov 5, 2015

With the latest libsodium 1.0.6 zeromq fails to compile

src/curve_client.cpp: In constructor 'zmq::curve_client_t::curve_client_t(const zmq::options_t&)':
src/curve_client.cpp:61:18: error: ignoring return value of 'int sodium_init()', declared with attribute warn_unused_result [-Werror=unused-result]
     sodium_init();

Same applies to src/curve_server.cpp, code already has a todo for this. Just wanted to let you know that this is now a compile error.

For openSUSE I am adding a patch something like

- sodium_init();
+ zeromq_assert (sodium_init() != -1);
@c-rack
Copy link
Member

c-rack commented Nov 5, 2015

See #1632
It is fixed in master branch long time ago and recently backported to 4-1.
Could you please try with libzmq from master branch and check if problem persists?

@ismail
Copy link
Author

ismail commented Nov 5, 2015

Ok so we did the same fix in the end, so no need to retest. Thanks!

@ismail ismail closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants