Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing files in Tarball #1952

Closed
afarbos opened this issue May 4, 2016 · 9 comments · Fixed by zeromq/zeromq4-1#121
Closed

Missing files in Tarball #1952

afarbos opened this issue May 4, 2016 · 9 comments · Fixed by zeromq/zeromq4-1#121

Comments

@afarbos
Copy link

afarbos commented May 4, 2016

Hi,

I tried to compile libzmq from the latest tarball (4.1.4) and it appears that some files/directory are missing : builds/cmake. Without these files we cannot compile the project with cmake.

Can you fix that ?

Also, why don't you tag your repository with release version?

Thanks,

@bluca
Copy link
Member

bluca commented May 4, 2016

It's fixed in libzmq master, I'll backport to 4.1.

@afarbos
Copy link
Author

afarbos commented May 13, 2016

The tarball available here (http://download.zeromq.org/zeromq-4.1.4.zip, http://download.zeromq.org/zeromq-4.1.4.tar.gz) are still not fixed. When will it be ?

@bluca
Copy link
Member

bluca commented May 13, 2016

It will not, as it's already released, and we can't retroactively change the content of a release. It will be included in 4.1.5.

@dvj
Copy link

dvj commented Aug 31, 2016

Note that 4.1.5 does not include version.rc.in, which is required for the cmake build on all platforms.

@bluca
Copy link
Member

bluca commented Sep 1, 2016

Is libzmq master make dist tarball also affected?

@bluca
Copy link
Member

bluca commented Sep 1, 2016

Self-answer: yes. I'll prepare a PR and send it to both. Thanks for bringing this up.

@bluca
Copy link
Member

bluca commented Sep 1, 2016

Opened #2096

@bluca
Copy link
Member

bluca commented Sep 2, 2016

@dvj - fixed in git for libzmq and zeromq4-1

@dvj
Copy link

dvj commented Sep 2, 2016

great, thanks for the quick action on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants