Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE tests generation under windows leads to linking error #2286

Closed
vtellier opened this issue Jan 1, 2017 · 3 comments
Closed

CMAKE tests generation under windows leads to linking error #2286

vtellier opened this issue Jan 1, 2017 · 3 comments

Comments

@vtellier
Copy link
Contributor

vtellier commented Jan 1, 2017

While trying to execute the tests I struggled a bit with their compilation.
The documentation (tests/README.md) says:

Building tests in Windows

Install CMAKE
CMD> CMAKE libzmq/tests
CMD> tests.sln
CMD> # build all projects in the solution

However I was faicing linking error on libzmq.lib.
After researches I found out these comments in tests/CMakeLists.txt:

# This is the output for Debug dynamic builds on Visual Studio 6.0
# You should provide the correct directory, don't know how to do it automatically
find_path(LIBZMQ_PATH "libzmq.lib" PATHS "../bin/Win32/Debug/v120/dynamic")

I just changed v120 to v140 as I am under Visual studio 2015 and it worked.
The thing is that it was the first time I used CMAKE so I spent some time trying to spot it.

Would it be possible to add a line about that in tests/README.md, or to make this fully automatic?

@bluca
Copy link
Member

bluca commented Jan 1, 2017

Please do send a PR to update the README and I'll merge it.

I'm not a Windows expert so not sure if it can be automated, hopefully someone else can help here.

@vtellier
Copy link
Contributor Author

vtellier commented Jan 2, 2017

For me the note in the README file is fair enough, would you like me to close the issue or should I keep it open until a Windows expert goes further?

@bluca
Copy link
Member

bluca commented Jan 2, 2017

Let's close it for now, if someone else on Windows wants to try and automate this they will

@bluca bluca closed this as completed Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants