Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coredump with option immediate and linger setted #2590

Closed
laplaceyang opened this issue Jun 1, 2017 · 4 comments
Closed

coredump with option immediate and linger setted #2590

laplaceyang opened this issue Jun 1, 2017 · 4 comments

Comments

@laplaceyang
Copy link
Contributor

laplaceyang commented Jun 1, 2017 •
edited
Loading

I set immediate = 1 and linger = 100, then my application always coredump in timer_event

qq 20170601103417

It seems the reconnect function of session_base implement incorrect.
image
In first block of this function, we set pipe to NULL, but has not cancel_timer. Thus, if the linger timer tiggered , we will get coredump.
@bluca
Copy link
Member

bluca commented Jun 1, 2017

Could you please send a PR to fix it?

@laplaceyang laplaceyang mentioned this issue Jun 2, 2017
Merged
@laplaceyang
Copy link
Contributor Author

@bluca
done. PR is here #2591

@bjovke
Copy link
Contributor

bjovke commented Jun 2, 2017

Merged.

@bluca
Copy link
Member

bluca commented Jun 2, 2017

Thanks!

@bluca bluca closed this as completed Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bluca @laplaceyang @bjovke