Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible buffer overflow in CURVE mechanism handshake #2681

Closed
sigiesec opened this issue Aug 14, 2017 · 0 comments
Closed

Possible buffer overflow in CURVE mechanism handshake #2681

sigiesec opened this issue Aug 14, 2017 · 0 comments

Comments

@sigiesec
Copy link
Member

sigiesec commented Aug 14, 2017

E.g., the function zmq::curve_client_t::produce_initiate contains the following lines:

    //  Assume here that metadata is limited to 256 bytes
    uint8_t initiate_plaintext [crypto_box_ZEROBYTES + 128 + 256];

One part of the metadata is the socket identity, which alone may be 255 bytes, so this is definitely too small.

The other mechanisms suffer from similar risks, but use larger buffers (512 bytes). Still, they do not check for overruns.

@sigiesec sigiesec changed the title Possible buffer overflow in zmq::curve_client_t::produce_initiate Possible buffer overflow in CURVE mechanism handshake Aug 15, 2017
@bluca bluca closed this as completed Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants