Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we change to furo theme? #565

Closed
zerothi opened this issue Apr 18, 2023 · 5 comments
Closed

Should we change to furo theme? #565

zerothi opened this issue Apr 18, 2023 · 5 comments

Comments

@zerothi
Copy link
Owner

zerothi commented Apr 18, 2023

Describe the feature

Should we change the documentation theme from rtd, to furo?

See the difference here:

What do you say?

@tfrederiksen @sofiasanz @pfebrer comments? Please note the installation tab which has some "tabs" that I think could be useful for doing various things.

@zerothi
Copy link
Owner Author

zerothi commented Apr 18, 2023

Remarkably the search function works in furo... Hmmm
.

@pfebrer
Copy link
Contributor

pfebrer commented Apr 18, 2023

I like the RTD theme better, I don't know why some packages are moving to other themes for documentation 😅

Of course if the search bar doesn't work that's something to consider... hahah

Is it only me or the furo theme gives a very large margin on the left?:

Screenshot from 2023-04-18 21-57-25

@zerothi
Copy link
Owner Author

zerothi commented Apr 18, 2023

Yeah, I had the same issue, but actually if you look at the two in neighbouring windows you'll see that RTD has the same margin, just left-aligned.

@pfebrer did you try the dark theme? I kind of like that one...

I think many have moved to furo since it is used by pip and some of its associated packages. So it is endorsed by the built-devs which always takes many followers :)
I just found this: readthedocs/sphinx_rtd_theme#1452

This seems to solve the issue, now searching should be back! :)

@zerothi
Copy link
Owner Author

zerothi commented Apr 19, 2023

Ok, we'll not change to furo. :)

@zerothi zerothi closed this as completed Apr 19, 2023
@tfrederiksen
Copy link
Contributor

I also tend to prefer RTD, mostly because this is what I'm used to. Great you found a fix for the search function!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants