Skip to content
This repository has been archived by the owner on Feb 15, 2021. It is now read-only.

CORS: using defaults in the settings file causes circular dependency. #40

Open
peymanmortazavi opened this issue Jul 17, 2017 · 1 comment

Comments

@peymanmortazavi
Copy link

If you import corsheaders.defaults.default_headers in your setting file to add a custom header to the list of default allowed headers, it'll fail due to circular dependency.

We can probably have a file just for constants and basic types like this and then reference them when needed. That way, we wouldn't have circular dependency.

@december1981
Copy link

In the latest version of django-cors-headers (of which this project is a fork), it appears this is not an issue... defaults.py does not import settings as it does in this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants