Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to yansi 1.0 #106

Closed
mohammadfawaz opened this issue Mar 26, 2024 · 1 comment · Fixed by #109
Closed

Upgrade to yansi 1.0 #106

mohammadfawaz opened this issue Mar 26, 2024 · 1 comment · Fixed by #109
Labels
good first issue Good for newcomers

Comments

@mohammadfawaz
Copy link
Contributor

mohammadfawaz commented Mar 26, 2024 •
edited
Loading

The yansi crate is now at 1.0. It's probably worth upgrading ariadne to use yansi v1.0 for two reasons:

  1. yansi 1.0 is hopefully more stable.
  2. Projects using ariadne that want to upgrade to yansi 1.0 will have an easier time if ariadne also uses yansi 1.0.
@zesterer zesterer added the good first issue Good for newcomers label Apr 6, 2024
@zesterer
Copy link
Owner

zesterer commented Apr 6, 2024

Yep, this is definitely something to be done. I'll try to find time over the next week or so.

@mohammadfawaz mohammadfawaz mentioned this issue Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump yansi to v1.0 mohammadfawaz/ariadne
2 participants
@zesterer @mohammadfawaz