You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey folks! Thanks for the cool addon and the latest refactoring! 👏
One minor thing came to my mind when I had a look at the currently failig CI:
I think the added performance test is not very meaningful, since you are also testing "how fast can we produce 10.000 array entries". Shouldn't we measure only the time when render-begin to render-end?
Further why add a minimum time for that test?
Cheers
The text was updated successfully, but these errors were encountered:
It's true it could be better, it's very approximate, but it does the job in catching this issue tracked-tools/tracked-built-ins#405, which was all I really wanted.
Hey folks! Thanks for the cool addon and the latest refactoring! 👏
One minor thing came to my mind when I had a look at the currently failig CI:
I think the added
performance
test is not very meaningful, since you are also testing "how fast can we produce 10.000 array entries". Shouldn't we measure only the time when render-begin to render-end?Further why add a minimum time for that test?
Cheers
The text was updated successfully, but these errors were encountered: