Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema: Focus the Reference Model Select Dropdown when creating a one to one relationship field and one to many relationship field #1905

Closed
zcolah opened this issue Mar 2, 2023 · 3 comments · Fixed by #1909
Assignees
Labels
enhancement Improvement to an existing feature

Comments

@zcolah
Copy link

zcolah commented Mar 2, 2023

Is your feature request related to a problem? Please describe.
When a user creates a one to one relationship field or one to many relationship field, we are currently making the label field as active which may result in them missing the fact that they need to set a reference model and a field to display.

Solution
Hence may we focus the Reference Model Select Dropdown when creating a one to one relationship field and one to many relationship field. See video for more context: https://www.loom.com/share/7587cef23ab544d89d756e03bc1fce1c

@zcolah zcolah added the enhancement Improvement to an existing feature label Mar 2, 2023
@agalin920
Copy link
Contributor

If we are autofocusing label for all other field types it doesn't make sense to have a inconsistent pattern

@zcolah
Copy link
Author

zcolah commented Mar 2, 2023

Andres the pattern is to auto focus the first field of the modal

@agalin920
Copy link
Contributor

agalin920 commented Mar 3, 2023

@zcolah mmm gotcha. I find making the label placement not consistent concerning. If for most fields your first action is to name the field why would that not be the case for some select ones?

Also for some fields options are at the bottom but for relationship it's at the top? Quite odd

Just feedback. Moving ticket forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants