Fix: Show legacy web headers #1911
Conversation
src/shell/services/headTags.ts
Outdated
| import { getResponseData, prepareHeaders } from "./util"; | ||
| import { LegacyHeader } from "./types"; | ||
|
|
||
| export const headTagApi = createApi({ |
There was a problem hiding this comment.
Our pattern isn't a new rtk query api per endpoint. It's per service. This endpoint is still on the instance service
There was a problem hiding this comment.
Gotcha, moved to instance.ts
src/shell/services/headTags.ts
Outdated
| getLegacyHeadTags: builder.query<LegacyHeader[], void>({ | ||
| query: () => `/web/headers`, | ||
| transformResponse: getResponseData, | ||
| keepUnusedDataFor: 0.0001, |
There was a problem hiding this comment.
Why does this need to exclude caching?
There was a problem hiding this comment.
Forgot to remove this when I copied the the block off of an already existing query
src/shell/services/headTags.ts
Outdated
| query: () => `/web/headers`, | ||
| transformResponse: getResponseData, | ||
| keepUnusedDataFor: 0.0001, | ||
| providesTags: () => [{ type: "LegacyHeadTags" }], |
There was a problem hiding this comment.
Providing tags here doesn't seem useful since nothing is invalidating it
There was a problem hiding this comment.
Removed on latest update
|
@theofficialnar besides the warning that there are legacy headtags present, do we display which headtags are legacy? |
@giseleblair yup, I've added it to the preview section of the head tag. Only issue I realized just now is that, the users will probably need to scan through the input fields first to find out which of these are considered legacy since I haven't indicated it on the preview - I honestly thought we just had to also make sure it's added there. |
Closes #497
Preview