Feat: Global Search Phase 8 and 9 #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* task: added sortby filter * task: rename sortby filter * task: add user filter * task: close menu on select * task: add select highlight * task: add date range to date filters * task: set params for daterange filter * task: set active filter text * task: remove date filter * task: pass active daterange value to daterange picker * fix: fixed ts error
* task: added sortby filter * task: rename sortby filter * task: add user filter * task: close menu on select * task: add select highlight * task: add date range to date filters * task: set params for daterange filter * task: set active filter text * task: remove date filter * task: pass active daterange value to daterange picker * fix: fixed ts error * - do not open a new tab when filters are added - unpin specific tab when search queries are present - show search keyword on tab name for the search page * task: sort by function * task: user filter * task: background color update * task: spacing fix * task: date filter func * task: updated result count * task: fixed alignment * task: added no results for filter
* task: added advanced search button * task: added filter button * chore: removed comment * task: added advanced search modal * task: fixed console errors * task: fixed console error * task: add form fields * task: added tooltips
* task: added advanced search button * task: added filter button * chore: removed comment * task: added advanced search modal * task: fixed console errors * task: fixed console error * task: add form fields * task: added tooltips * task: created hook for advance search data * task: moved search data to content search comp * task: added clear all function * task: wire user filter * task: import types * task: moved everything back into the advance search modal * task: moved date config to a separate file & added daterange modal * task: added date handling for single date picker * task: daterange handler * task: wired advance search page * task: wired advance search function * task: spacing and color update * fix: fixed search button not enabling * task: added cypress test scenarios * task: search page cypress tests * task: advance search modal cypress tests * task: added data-cy * task: updated cy get chaining * fix: height fix for the counter * task: added tooltips and changed date filter to modified at * task: vqa updates * task: adjusted border radius
…bal-search-phase2
…bal-search-phase-3
* task: always open the dropdown on click * task: add recent searches hook * task: add recent searches to dropdown * task: created separated component for global search items * task: updated subheader style * task: padding updates * task: cleanup * task: unfocus textfield when user selects an item * task: always show user typed value * task: removed comment * task: wire remove recent search * task: save a max of 50 recent search items * task: when user keyword exists as a saved recent search, render it as a recent search * task: hide suggestions when no user-typed keyword is present * task: fixed incorrect icon * task: remove manual JSON.parse/stringify * task: removed deep cloning
…bal-search-phase-3
* task: added resource type filter * task: updated tooltip text * task: add resource type filter component in search page
* task: created util to get content title * task: changed how content result is being taken * task: created filtered models hook * task: show models in top suggestions * task: moved getting icon to utils * task: added model type keyword matching * task: changed model search hook * task: update comment * chore: added hook description * task: search models via user zuid * task: allow searching models via user name * task: changed how data is taken from rtk query * task: show models in search page results * task: render model list item * task: wire resource type filter * task: cleanup * task: added icons to dropdown options
…bal-search-phase-4
…bal-search-phase-4
* task: created util to get content title * task: changed how content result is being taken * task: created filtered models hook * task: show models in top suggestions * task: moved getting icon to utils * task: added model type keyword matching * task: changed model search hook * task: update comment * chore: added hook description * task: search models via user zuid * task: allow searching models via user name * task: changed how data is taken from rtk query * task: show models in search page results * task: render model list item * task: wire resource type filter * task: cleanup * task: create rtk query for scripts and stylesheets * task: add hook to filter code files * task: include code files in top suggestions * task: support view and snippet files for .html searches * task: remove unneeded special handling for .html search * task: add code to resource type filter dropdowns * task: fixed type errors * task: change type for resource types
…bal-search-phase-5
…ger-ui into task/code-files-search-page
…bal-search-phase-6
finnar-bin
changed the title
This has been addressed |
agalin920
approved these changes
Jul 13, 2023
finnar-bin
changed the title
finnar-bin
changed the title
agalin920
approved these changes
Jul 13, 2023
zcolah
suggested changes
Jul 13, 2023
There was a problem hiding this comment.
Great job like always Nar.
- Can you ensure this is not case sensitive? So that it allows "in:content", etc.
- This is not part of the original spec but can you add the following keyboard interactions
- When the user clicks on the down arrow key please allow them to also toggle between the accelerators (see how Slack does this)
- When the user clicks on tab please allow them to toggle down to the next item, similar to what the down arrow key interaction does (see how Slack does this).
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global Search Phase 9
Global Search Phase 8 (Enhancements)
Note:
This PR is based off of #2102. So it might currently show changes that are already on that PR since it is not yet merged.
Preview
Peek.2023-07-13.10-35.webm