Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Content app sidebar redesign #2197

Merged
merged 117 commits into from
Aug 10, 2023
Merged

Conversation

finnar-bin
Copy link
Contributor

@finnar-bin finnar-bin commented Jul 31, 2023

Note:

This PR is dependent on zesty-io/material#78 for proper styling

Preview

content-app-sidebar.webm

@finnar-bin finnar-bin requested review from agalin920 and zcolah August 2, 2023 10:03
@zcolah zcolah added the vqa VQA is complete and approved label Aug 2, 2023
Copy link

@zcolah zcolah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Visually no issues
  2. The filter models input is behaving a little laggy and slow
  3. I unfortunately cannot expand and collapse most menu list items (not sure why)
  4. Loom on the above: https://www.loom.com/share/3ec8d95cd84842d285a102e871bc9793?from_recorder=1&focus_title=1

Copy link
Contributor

@agalin920 agalin920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@finnar-bin
Copy link
Contributor Author

@agalin920 I'll try to look for a way to optimize how the tree data is built. As for the NavTree being rendered 3 times, I don't think there's really any way around it since I had to put in 3 different NavTree components, each for Pages, Headless and Hidden items.

I do agree that flattening out the filter list would make it faster since we'll only have to render 1 NavTree in that case but I think I still have to make some loops to add in the icons and the hover action elements for each nav item that matches the filter keyword.

@agalin920
Copy link
Contributor

@theofficialnar Ah got ya didn't realize it was three different ones. Disregard comment

@agalin920 agalin920 self-requested a review August 6, 2023 23:29
@finnar-bin finnar-bin added the ready PR is complete and ready for deployment label Aug 7, 2023
@shrunyan shrunyan merged commit fd9a41b into master Aug 10, 2023
@shrunyan shrunyan deleted the feature/content-sidebar-redesign branch August 10, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is complete and ready for deployment vqa VQA is complete and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content: App Sidebar Revamp Reordering content navigation tree not working properly
4 participants