-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Content app sidebar redesign #2197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Visually no issues
- The filter models input is behaving a little laggy and slow
- I unfortunately cannot expand and collapse most menu list items (not sure why)
- Loom on the above: https://www.loom.com/share/3ec8d95cd84842d285a102e871bc9793?from_recorder=1&focus_title=1
… actions is being placed
…o/manager-ui into feature/content-sidebar-redesign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
@agalin920 I'll try to look for a way to optimize how the tree data is built. As for the NavTree being rendered 3 times, I don't think there's really any way around it since I had to put in 3 different NavTree components, each for Pages, Headless and Hidden items. I do agree that flattening out the filter list would make it faster since we'll only have to render 1 NavTree in that case but I think I still have to make some loops to add in the icons and the hover action elements for each nav item that matches the filter keyword. |
@theofficialnar Ah got ya didn't realize it was three different ones. Disregard comment |
Note:
This PR is dependent on zesty-io/material#78 for proper styling
Preview
content-app-sidebar.webm