Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Settings sidebar revamp #2266

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Feature: Settings sidebar revamp #2266

merged 9 commits into from
Oct 2, 2023

Conversation

finnar-bin
Copy link
Contributor

Closes #2169

Preview

settings

@finnar-bin finnar-bin self-assigned this Sep 17, 2023
@finnar-bin finnar-bin marked this pull request as ready for review September 17, 2023 22:52
agalin920
agalin920 requested changes Sep 17, 2023
View reviewed changes
src/shell/services/types.ts Outdated Show resolved Hide resolved
zcolah
zcolah suggested changes Sep 18, 2023
View reviewed changes
Copy link

@zcolah zcolah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job as always @theofficialnar. Two key things to fix.

  1. Empty State defined is not present
CleanShot 2023-09-18 at 13 54 24@2x
  1. Please make the default width of all sidebars to be the minimum width rather than being a width between the min and max.

@zcolah zcolah added the vqa VQA is complete and approved label Sep 27, 2023
@finnar-bin finnar-bin added the ready PR is complete and ready for deployment label Sep 27, 2023
@shrunyan shrunyan merged commit 31ddf51 into master Oct 2, 2023
1 check failed
@shrunyan shrunyan deleted the feature/settings-sidebar-revamp branch October 2, 2023 19:38
This was referenced Mar 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcolah zcolah zcolah requested changes

@agalin920 agalin920 agalin920 approved these changes

Assignees

@finnar-bin finnar-bin

Labels
ready PR is complete and ready for deployment vqa VQA is complete and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings: Sidebar Revamp
4 participants
@finnar-bin @agalin920 @zcolah @shrunyan