Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update cypress version #2288

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix: Update cypress version #2288

merged 2 commits into from
Oct 9, 2023

Conversation

finnar-bin
Copy link
Contributor

@finnar-bin finnar-bin commented Oct 5, 2023

Closes #2289

Updating Cypress to version 12 because of an issue with Chrome 117 where Cypress tests fail to run in chrome headless mode.
For reference: cypress-io/cypress#22163 (comment)

@finnar-bin finnar-bin self-assigned this Oct 5, 2023
@finnar-bin finnar-bin marked this pull request as ready for review October 5, 2023 04:27
@agalin920
Copy link
Contributor

@theofficialnar Wouldn't we expect this to pass?

@finnar-bin
Copy link
Contributor Author

@theofficialnar Wouldn't we expect this to pass?

Yeah, I'm actually still looking into why that specific test is failing since it passes on local.

@agalin920 agalin920 merged commit 862f26d into master Oct 9, 2023
1 check passed
@agalin920 agalin920 deleted the fix/cypress-version-update branch October 9, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress tests failing to run
2 participants