-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DUO Mode: Switch on DUO Mode for Existing and New Customers #2399
Comments
@zcolah DUO mode is turned on by default if they have it enabled |
@agalin920 this is a ticket that is WIP with Randy. Not yet assigned to any developers therefore. |
These settings when present disable duomode |
@giseleblair @agalin920 i already create a branch (https://github.com/zesty-io/template-pomelo/tree/enable-duo-mode) for this, removing the setting to enable duo mode but the installer template installation does not support deletion of settings. it only updates or creates settings. with this, i think we must also need to delete those settings on the "template base blueprint" since this blueprint creates the base or default setting for the instance before the installer updates or creates the settings for template. |
I believe that template base blueprint only exists in the database, can you confirm @allenpigar |
@giseleblair yes it exist on the database and sql scripts are need to update. but as we have discussed, there no need to remove those settings and just set the default value to null. with this, we can just update the values on the template itself without any changes on the blueprint. i already created pr for review. zesty-io/template-blank#2 |
@giseleblair it seems like there's nothing needed to done in manager-ui for this ticket anymore as I tried creating new instances using all the existing templates are they all have duo mode enabled by default already. I checked in with @allenpigar and he has confirmed that he changed the template's default values for the following settings (basic_content_api_key, headless_authorization_key, authorization_key and x_frame_options) to |
@finnar-bin please refer to my screenshot above in the thread (from Jan 3) and test with those values. Duo mode needs to work with the those values not just the null values from the templates |
@giseleblair so just to clarify, the goal here is to make sure that duo mode is activated if those settings are either null or contain the specific values you mentioned? |
@finnar-bin Duo mode does not get activated by these settings. But the goal is that when Duo Mode is turned on, AND the above settings are either null or the specific mentioned values that the Duo Mode frame will render the page as expected. Currently, the values MIUST be null in order for the Duo Mode frame to render. But we want to update this logic so it will also work with the mentioned values. |
Note to self: CSP needs to be validated as well |
@giseleblair is there a need to validate that the value for Referrer-Policy be either null or "strict-origin-when-cross-origin" for the duo mode toggle to be visible? I've already tested the CSP setting and it seems like what works is |
I believe that CSP will trump the Referrer-Policy value @finnar-bin but it is still worth validating in the order of operations |
Problem
Customers do not know about DUO Mode and how to start it. We just want to start it for existing customers and new customers/instance in the future.
Solution Steps
Specifically this solution is based around a content policy setting.
The text was updated successfully, but these errors were encountered: