fix: Content: SEO Meta Description Displays that there are excess characters when there are none #2534
Conversation
glespinosa
changed the title
There was a problem hiding this comment.
@glespinosa did you check with @zcolah if the expected behavior here is to automatically trim the user input instead of retaining the excess characters and letting the user fix it themselves before it gets saved?
@theofficialnar currently this is the approach we are taking as it is the behavior that was already being followed for the other fields on the SEO Tab. We definitely want an error blurb like experience for SEO in the near future though. |
| @@ -40,6 +41,10 @@ export default connect()(function MetaDescription({ | |||
| } | |||
|
|
|||
| setError(message); | |||
|
|
|||
| if (isSaving) { | |||
There was a problem hiding this comment.
You are accessing isSaving variable but it's not a dependency of the useEffect?
There was a problem hiding this comment.
@agalin920 yes for now it's relying on the useEffect since everytime the user is saving that's the only time I can rerun the onChange function to check the characters condition on excess. I'm adding it now as dependency on useEffect
There was a problem hiding this comment.
@agalin920 I removed now the useEffect on every component and let the useEffect inside of ItemSettings do the work of removing the errors while on there are on saving... Then i slice all the props base on the number of allowed character on the properties in the /shell/store/content.js
…of removing errors when there are errors while saving
src/shell/store/content.js
Outdated
| item.web.metaLinkText = item.web.metaLinkText.slice(0, 150); | ||
| } | ||
| if (item.web.metaKeywords) { | ||
| item.web.metaKeywords = item.web.metaKeywords.slice(0, 250); |
There was a problem hiding this comment.
Why is it 250 here? The ui's character counter says it's 255. Probably worth checking in with @markelmad what the expected char limit here is.
There was a problem hiding this comment.
done updating changes
There was a problem hiding this comment.
@glespinosa which character count did we settle on and why?
There was a problem hiding this comment.
@shrunyan I'm basing on the UI
This will also solve problem in Meta Title, Meta Keywords, Navigation Link Text not only in the Meta Descriptions because they share same issues regarding excess characters
screencast-8-aaeffee09b-7w6v22.manager.dev.zesty.io_8080-2024.02.06-09_19_45.webm
Closes #2501 #2502