Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove upstream dependencies #85

Closed
Tracked by #2403
fbac opened this issue Jul 24, 2024 · 1 comment · Fixed by #87
Closed
Tracked by #2403

chore: remove upstream dependencies #85

fbac opened this issue Jul 24, 2024 · 1 comment · Fixed by #87
Assignees

Comments

@fbac
Copy link
Contributor

fbac commented Jul 24, 2024

Remove upstream ethermint dependencies and rely solely on zeta-chain/ethermint codebase.

Ideally we'd shift away from evmos/ethermint. Why are we using evmos/ethermint instead of our own types from types/encoding.go, which also export EncodingConfig?

Originally posted by @fbac in #83 (comment)

@gartnera
Copy link
Member

We're not importing github.com/evmos/ethermint, that's the current name of this module.

We'd need to rename the module and change the replace in node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants