Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observer: Revise policy type names #932

Closed
Tracked by #1034
lumtis opened this issue Aug 9, 2023 · 4 comments · Fixed by #1169
Closed
Tracked by #1034

observer: Revise policy type names #932

lumtis opened this issue Aug 9, 2023 · 4 comments · Fixed by #1169
Assignees

Comments

@lumtis
Copy link
Member

lumtis commented Aug 9, 2023

Context: #912 (comment)

Make a walkthrough of the different policy types and rename them appropriately depending on their usage.

@lumtis
Copy link
Member Author

lumtis commented Sep 11, 2023

Did a walkthrough of the types:

  • Policy_Type_stop_inbound_cctx: can update permission flags to disable inbound and outbound in cctx.

Should be renamed

  • Policy_Type_deploy_fungible_coin - can:
    • Whitelist ERC20
    • Deploy foreign coin
    • Remove foreign coin
    • Update system contract
    • Pause ZRC20
    • Update ZRC20 bytecode
    • Update withdraw fees

Should be renamed

  • Policy_Type_update_client_params - update core params, looks up-to-date although client_params could be renamed into core_params

  • Policy_Type_update_keygen_block - update TSS address and Keygen

Should be renamed

  • Policy_Type_out_tx_tracker - Add to out tx tracker or remove from out tx tracker, looks up-to-date

  • Policy_Type_add_observer - Add observer, looks up-to-date

We might also want to merge some of the rule to simplify the authorization structure.

cc @zeta-chain/protocol-engineering

@fadeev
Copy link
Member

fadeev commented Sep 11, 2023

Create a doc with all the privileged message types. Depending on how complex this ends up being, we might consolidate the roles.

@lumtis
Copy link
Member Author

lumtis commented Sep 12, 2023

Update: doc set up on Notion: Engineering / Protocol Docs / Observer Policy Types

@fadeev
Copy link
Member

fadeev commented Sep 18, 2023

@fadeev fadeev linked a pull request Sep 25, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants