-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gltfpack: floating point attributes for normals #632
Comments
I would recommend -vn 12 instead. |
I have tried with |
If you're still seeing them with |
Yes. Models are quite large: https://drive.google.com/drive/folders/1lkT9YFSFEx-MgRC-G8YAaGlb3GDlz9Ow?usp=drive_link I also added a imgur post link so you can directly see the models without having to download them. I used https://gltf-viewer.donmccurdy.com to view models. Let me know if you have viewed the models and I'll make the folder private, |
Thanks - feel free to delete the files, I'll need to debug this later. |
Thank you! |
This is a similar problem to #515 -- the model uses morph target based animation by just serializing keyframes as morph targets, and currently the range of normals is always |
Currently, positions can use floating point attributes with:
But normals are always quantized. I'm seeing little artifacts in the model with normal attributes which are not present in uncompressed model. When I reduced the quantization bits from default (8) to 4, the artifacts became severe => Artifacts are due to quantization.
I would love a flag to use floating point attributes for normals. Like below:
The text was updated successfully, but these errors were encountered: