feat: add sonarjs plugin #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beawar
requested review from
gnekoz,
dhavaldodiya,
CataldoMazzilli,
lisaparma,
CerDennis,
FrancescoGottardi,
nubsthead,
yukiLu6,
giuliano176 and
zextras-vijay
giuliano176
approved these changes
Apr 24, 2023
nubsthead
approved these changes
Apr 27, 2023
CataldoMazzilli
approved these changes
May 8, 2023
CerDennis
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sonarjs plugin to eslint and use the recommended configuration, which is a subset of the configuration for js and ts of SonarQube (see https://rules.sonarsource.com/typescript and https://rules.sonarsource.com/javascript).
Given that, it is suggested installing also SonalLint plugin for the IDE.
In case there are too many errors generated by this new rules in your project, override the needed rules in your eslint configuration, setting them with type 'warn', and progressively fix the warnings. When you feel comfortable, remove the override and return to have the default rules set to type 'error'.