Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding causes studders if the intial state is closed in 3.0.1 #16

Closed
mrkmiller opened this issue Jul 26, 2021 · 4 comments · Fixed by #19 or #27
Closed

Padding causes studders if the intial state is closed in 3.0.1 #16

mrkmiller opened this issue Jul 26, 2021 · 4 comments · Fixed by #19 or #27
Assignees
Labels
bug Something isn't working

Comments

@mrkmiller
Copy link

Padding on the element being toggled now causes problems in 3.0.1 if the initial state is closed.

How to reproduce:

  1. Edit the demo "show" event and change the speed to 2000ms so it can be better seen.
  2. Edit the .section .toggle-list .toggled-list-element and add a top and bottom padding of 100px.

Instead of slowly sliding all content open, it will immediately display all content based on the height of the combined padding before sliding open the rest.
image

@zgrybus zgrybus self-assigned this Jul 26, 2021
@zgrybus zgrybus linked a pull request Aug 21, 2021 that will close this issue
@zgrybus
Copy link
Owner

zgrybus commented Aug 21, 2021

@mrkmiller Fixed in 3.2.1

@mrkmiller
Copy link
Author

Thanks for the work... but unfortunately this still appears to be a problem in 3.2.2. I created a codepen to demo content using no padding vs having padding.
https://codepen.io/segovia94/pen/mdwybgK

@mrkmiller
Copy link
Author

Actually, this appears to only be an issue within Firefox now. Chrome is working fine.

@zgrybus zgrybus reopened this Aug 25, 2021
@zgrybus zgrybus added the bug Something isn't working label Aug 25, 2021
@zgrybus zgrybus linked a pull request Dec 14, 2021 that will close this issue
@zgrybus zgrybus reopened this Dec 14, 2021
@zgrybus
Copy link
Owner

zgrybus commented Feb 9, 2023

Hi @mrkmiller.
I'm really sorry for the long wait for an answer..

I ported this library to the Animation API (https://github.com/zgrybus/slideToggle/releases/tag/v4.0.0). Can you check if this issue still occurs? show and hide should be fixed. My guess is that this switch still has a bug which I will fix in the next version (v4.0.1)

@zgrybus zgrybus closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants