Skip to content

Commit 17a294b

Browse files
Jonah Williamsyuuangzhang
authored andcommitted
[Impeller] remove validation warning ignores. (flutter#166205)
We have validation enabled on CI and these don't seem to fail now that I've removed the VVL ignore. Fixes flutter#149111
1 parent 34cf12b commit 17a294b

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

engine/src/flutter/impeller/renderer/backend/vulkan/debug_report_vk.cc

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -117,21 +117,6 @@ DebugReportVK::Result DebugReportVK::OnDebugCallback(
117117
if (data->messageIdNumber == 0x609A13B) {
118118
return Result::kContinue;
119119
}
120-
// TODO(149111): Fix VUID-VkShaderModuleCreateInfo-pCode-08737.
121-
if (data->pMessageIdName != nullptr &&
122-
strcmp(data->pMessageIdName,
123-
"VUID-VkShaderModuleCreateInfo-pCode-08737") == 0) {
124-
return Result::kContinue;
125-
}
126-
// TODO(149111): Fix
127-
// VUID-VkPipelineShaderStageCreateInfo-pSpecializationInfo-06849.
128-
if (data->pMessageIdName != nullptr &&
129-
strcmp(
130-
data->pMessageIdName,
131-
"VUID-VkPipelineShaderStageCreateInfo-pSpecializationInfo-06849") ==
132-
0) {
133-
return Result::kContinue;
134-
}
135120

136121
// This warning happens when running tests that use SwiftShader.
137122
// Some SPIR-V shaders request the UniformAndStorageBuffer16BitAccess
@@ -145,7 +130,6 @@ DebugReportVK::Result DebugReportVK::OnDebugCallback(
145130
std::vector<std::pair<std::string, std::string>> items;
146131

147132
items.emplace_back("Severity", vk::to_string(severity));
148-
149133
items.emplace_back("Type", vk::to_string(type));
150134

151135
if (data->pMessageIdName) {

0 commit comments

Comments
 (0)