Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_evaluation() implemented wrong #132

Closed
RottenSchnitzel opened this issue May 19, 2023 · 2 comments
Closed

get_evaluation() implemented wrong #132

RottenSchnitzel opened this issue May 19, 2023 · 2 comments

Comments

@RottenSchnitzel
Copy link

RottenSchnitzel commented May 19, 2023 •
edited
Loading

When calling get_evaluation() I expect the command eval to be put into stockfish. Currently the skript just executes a bestmove search and then uses the score of stockfishs best move.

This feature makes sense but is very misleading since it is called "get_evaluation". Maybe name it "get_bestmove_score" and actually call eval for "get_evaluation".

Very quick fix would be to at least add a note in the Readme.
@kieferro
Copy link
Contributor

This project is now maintained here (#130). Could you close this issue here and open it again on the fork? Thanks

@RottenSchnitzel
Copy link
Author

sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RottenSchnitzel @kieferro