Skip to content

Commit f835c89

Browse files
committed
AStyle: fix indentation for longer lines
Long lines like this would have parameters misaligned but shorter lines would be OK. ``` void LoRaMac::check_frame_size(uint16_t size) { uint8_t value = _lora_phy.get_max_payload(_mcps_indication.rx_datarate, - _params.is_repeater_supported); + _params.is_repeater_supported); + + _lora_phy.a(_mcps_indication.b, + b.is_repeater_supported); ``` With this option (applied to the code above), we get ``` @@ -319,6 +319,9 @@ void LoRaMac::check_frame_size(uint16_t size) uint8_t value = _lora_phy.get_max_payload(_mcps_indication.rx_datarate, _params.is_repeater_supported); + _lora_phy.a(_mcps_indication.b, + b.is_repeater_supported); ``` Both are aligned the same. However there is a limit of astyle - 120 columns for this. We do in most cases lines from 80 to 120 as suggested in our code lines thus this should be good.
1 parent 1059c26 commit f835c89

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.astylerc

+4
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,7 @@ align-reference=name
3131
# Attach { for classes and namespaces
3232
attach-namespaces
3333
attach-classes
34+
35+
# Extend longer lines, define maximum 120 value. This results in aligned code,
36+
# otherwise the lines are broken and not consistent
37+
max-continuation-indent=120

0 commit comments

Comments
 (0)