Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIT: Hard-coded shared object in Makefile #3

Open
GarrettVD opened this issue May 23, 2019 · 0 comments
Open

NIT: Hard-coded shared object in Makefile #3

GarrettVD opened this issue May 23, 2019 · 0 comments

Comments

@GarrettVD
Copy link

Hi @zhunki

First of all, great work on this. I'd been working on and off on a syntax-aware fuzzer using this AST mutation approach myself. So, I'm glad you put in the foot-work to do this already.

Just a minor NIT here. I'd been receiving numerous Invalid Syntax errors while running afl-fuzz on an instrumented JavaScriptCore build, until I realized that the Makefile I'd built afl-fuzz with included a hard-coded reference to the PHP parser shared library. I suggest either (or both) of the following:

  1. Making this parameter configurable within the Makefile with a default value
  2. Updating the README.md to make it more apparent

If you'd rather I open a PR for this, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant