Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this list alive? #1231

Closed
alexkart opened this issue Oct 31, 2023 · 16 comments
Closed

Is this list alive? #1231

alexkart opened this issue Oct 31, 2023 · 16 comments

Comments

@alexkart
Copy link
Collaborator

alexkart commented Oct 31, 2023

Is this list alive? It doesn't look like it is being updated and accepts pull requests.

@dereuromark
Copy link
Collaborator

I have been wondering this for a bit.

Idea:
Let's start a new list under a less bus-factor namespace (no private space), with a few collaborators that want to join in to keep the list up to date and alive.

https://github.com/php-collective/awesome-php

Feel free to push things there, maybe we can work off some of the PRs here in reverse order (newest first).

Anyone who wants to be a collaborator, ping me on the new repo (e.g. via issue)

@dereuromark
Copy link
Collaborator

Update:
We are still waiting to be officially switched out
In the meantime:
We are still looking for experienced and trustworthy open source devs that would be willing to help out maintain the new PHP awesome list. Please reach out there in the tickets if you feel the calling.

@ziadoz
Copy link
Owner

ziadoz commented Dec 30, 2023

I haven't had the energy necessary to maintain this list for a while now. I've also had a terrible 2023, which hasn't helped.

I would like to keep this list alive and active though. @dereuromark Rather than creating and promoting fork, are you interested in being a collaborator on this repo instead? The guidelines are here.

@dereuromark
Copy link
Collaborator

Would that be with commit/merge rights? Then we can do it.
In general we should be >= 3 to avoid any future bus factor etc.

@ziadoz
Copy link
Owner

ziadoz commented Dec 30, 2023

Would that be with commit/merge rights? Then we can do it.

@dereuromark Yes. I've sent you an invite.

In general we should be >= 3 to avoid any future bus factor etc.

I'm happy to bring on more people. Who is collaborating on your fork?

@alexkart
Copy link
Collaborator Author

Who is collaborating on your fork?

Hi. I am.

@dereuromark
Copy link
Collaborator

We should port the changes over that we already did on the fork then.

@ziadoz
Copy link
Owner

ziadoz commented Dec 30, 2023

Hi. I am.

@alexkart I've invited you too.

If either you have any questions let me know. Thanks.

@alexkart
Copy link
Collaborator Author

alexkart commented Jan 4, 2024

If either you have any questions let me know. Thanks.

@ziadoz
There are numerous open PRs without any responses that appear valid and eligible for merging. Are there specific reasons why they haven't been merged yet?

@dereuromark
Copy link
Collaborator

We need to also investigate the awesomeness of each
And usually we should have 2+ signoffs / approvals before merging

But I agree we should start approving

@ziadoz
Copy link
Owner

ziadoz commented Jan 5, 2024

@ziadoz There are numerous open PRs without any responses that appear valid and eligible for merging. Are there specific reasons why they haven't been merged yet?

Sorry, I don't have a decision on many of the open requests. I imagine a lot of the older PRs can be closed, especially if the packages are archived, haven't been updated in several years, or aren't compatible with PHP 8.0. I've tackled a few ones I knew I planned to merge and reject. I'm happy for you to make your own judgements on things though.

@alexkart
Copy link
Collaborator Author

alexkart commented Jan 5, 2024

OK, let's maybe make a rule, as @dereuromark suggested: for a PR to be merged, it must receive at least 2 approvals from the collaborators; what do you think?

@ziadoz
Copy link
Owner

ziadoz commented Jan 8, 2024

OK, let's maybe make a rule, as @dereuromark suggested: for a PR to be merged, it must receive at least 2 approvals from the collaborators; what do you think?

I'm happy with having with two approvals for a merge, but I don't think it should be a hard requirement. Some things are obvious enough to merge (e.g. typos, broken links, formatting, package upgrades), and I trust you both to make decisions.

@alexkart
Copy link
Collaborator Author

alexkart commented Jan 9, 2024

I'm happy with having with two approvals for a merge, but I don't think it should be a hard requirement. Some things are obvious enough to merge (e.g. typos, broken links, formatting, package upgrades), and I trust you both to make decisions.

Yes, definitely, I meant those PRs that add new things to the list.

@alexkart
Copy link
Collaborator Author

alexkart commented Jan 9, 2024

Also, I think we can close this issue.

@alexkart alexkart closed this as completed Jan 9, 2024
@ziadoz
Copy link
Owner

ziadoz commented Jan 10, 2024

I've updated COLLABORATING.MD to clarify things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants