Sema: fix crash when coercing error/optional int type at comptime

Author: rmehri01

src/Sema.zig

@@ -29153,15 +29153,15 @@ fn coerceExtra(
 
         // E!T to T
         if (inst_ty.zigTypeTag(zcu) == .error_union and
-            (try sema.coerceInMemoryAllowed(block, inst_ty.errorUnionPayload(zcu), dest_ty, false, target, dest_ty_src, inst_src, maybe_inst_val)) == .ok)
+            (try sema.coerceInMemoryAllowed(block, inst_ty.errorUnionPayload(zcu), dest_ty, false, target, dest_ty_src, inst_src, null)) == .ok)
         {
             try sema.errNote(inst_src, msg, "cannot convert error union to payload type", .{});
             try sema.errNote(inst_src, msg, "consider using 'try', 'catch', or 'if'", .{});
         }
 
         // ?T to T
         if (inst_ty.zigTypeTag(zcu) == .optional and
-            (try sema.coerceInMemoryAllowed(block, inst_ty.optionalChild(zcu), dest_ty, false, target, dest_ty_src, inst_src, maybe_inst_val)) == .ok)
+            (try sema.coerceInMemoryAllowed(block, inst_ty.optionalChild(zcu), dest_ty, false, target, dest_ty_src, inst_src, null)) == .ok)
         {
             try sema.errNote(inst_src, msg, "cannot convert optional to payload type", .{});
             try sema.errNote(inst_src, msg, "consider using '.?', 'orelse', or 'if'", .{});

test/cases/compile_errors/comptime_coercing_int_error_union_doesnt_crash.zig

@@ -0,0 +1,11 @@
+const std = @import("std");
+pub fn main() !void {
+    const x = 0;
+    comptime {
+        x += std.math.add(usize, x, 2);
+    }
+}
+
+// error
+//
+// :5:26: error: expected type 'comptime_int', found 'error{Overflow}!usize'

test/cases/compile_errors/comptime_coercing_int_optional_doesnt_crash.zig

@@ -0,0 +1,12 @@
+const std = @import("std");
+pub fn main() !void {
+    const x = 0;
+    const y: ?usize = null;
+    comptime {
+        x += y;
+    }
+}
+
+// error
+//
+// :6:14: error: expected type 'comptime_int', found '?usize'