IoUring: fix and remove TODOs

backout from updating `pipe2` syscall to use Pipe2 flags

Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>

Author: bernardassan

lib/std/os/linux.zig

@@ -1335,7 +1335,7 @@ pub fn pipe(fd: *[2]i32) usize {
     }
 }
 
-pub fn pipe2(fd: *[2]i32, flags: Pipe2) usize {
+pub fn pipe2(fd: *[2]i32, flags: O) usize {
     return syscall2(.pipe2, @intFromPtr(fd), @as(u32, @bitCast(flags)));
 }
 

lib/std/os/linux/IoUring.zig

@@ -927,12 +927,9 @@ pub fn bind(
     fd: linux.fd_t,
     addr: *const linux.sockaddr,
     addrlen: linux.socklen_t,
-    // liburing doesn't have this flag, hence 0 should be passed
-    // TODO: consider removing this and all flags like this
-    flags: u32,
 ) !*Sqe {
     const sqe = try self.get_sqe();
-    sqe.prep_bind(fd, addr, addrlen, flags);
+    sqe.prep_bind(fd, addr, addrlen);
     sqe.user_data = user_data;
     return sqe;
 }
@@ -945,12 +942,9 @@ pub fn listen(
     user_data: u64,
     fd: linux.fd_t,
     backlog: u32,
-    // liburing doesn't have this flag, hence 0 should be passed
-    // TODO: consider removing this and all flags like this
-    flags: u32,
 ) !*Sqe {
     const sqe = try self.get_sqe();
-    sqe.prep_listen(fd, backlog, flags);
+    sqe.prep_listen(fd, backlog);
     sqe.user_data = user_data;
     return sqe;
 }
@@ -3509,26 +3503,21 @@ pub const Sqe = extern struct {
         sqe.set_target_fixed_file(file_index);
     }
 
-    // TODO: maybe remove unused flag fields?
     pub fn prep_bind(
         sqe: *Sqe,
         fd: linux.fd_t,
         addr: *const linux.sockaddr,
         addrlen: linux.socklen_t,
-        flags: u32, // flags is unused and does't exist in io_uring's api
     ) void {
         sqe.prep_rw(.bind, fd, @intFromPtr(addr), 0, addrlen);
-        sqe.rw_flags = flags;
     }
 
     pub fn prep_listen(
         sqe: *Sqe,
         fd: linux.fd_t,
         backlog: u32,
-        flags: u32, // flags is unused and does't exist in io_uring's api
     ) void {
         sqe.prep_rw(.listen, fd, 0, backlog, 0);
-        sqe.rw_flags = flags;
     }
 
     pub fn prep_cmd_sock(
@@ -4466,8 +4455,7 @@ pub const uflags = struct {
         link_timeout_update: bool = false,
         /// Available since Linux 5.16
         timeout_etime_success: bool = false,
-        // COMMIT: new Timeout Flag
-        // TODO: add when it became available
+        /// Available since Linux 6.4
         timeout_multishot: bool = false,
         _8: u25 = 0,
     };
@@ -4487,7 +4475,6 @@ pub const uflags = struct {
         /// Multishot poll. Sets IORING_CQE_F_MORE if the poll handler will
         /// continue to report CQEs on behalf of the same SQE.
         add_multi: bool = false,
-        // TODO: verify this doc comment is valid for the 2 flags below
         /// IORING_POLL_UPDATE
         /// Update existing poll request, matching sqe.addr as the old user_data
         /// field.
@@ -4807,8 +4794,6 @@ pub const Op = enum(u8) {
     bind,
     listen,
     recv_zc,
-    // COMMIT: new OPs
-    // TODO: to be implemented
     epoll_wait,
     readv_fixed,
     writev_fixed,
@@ -4817,20 +4802,6 @@ pub const Op = enum(u8) {
     _,
 };
 
-// TODO: I don't see these types in liburing and on a ddg search
-// Maybe they should be removed
-pub const io_uring_notification_slot = extern struct {
-    tag: u64,
-    resv: [3]u64,
-};
-pub const io_uring_notification_register = extern struct {
-    nr_slots: u32,
-    resv: u32,
-    resv2: u64,
-    data: u64,
-    resv3: u64,
-};
-
 test "structs/offsets/entries" {
     if (!is_linux) return error.SkipZigTest;
 
@@ -7519,8 +7490,8 @@ test "bind/listen/connect" {
         var optval: u32 = 1;
         (try ring.setsockopt(2, listen_fd, .socket, .reuseaddr, mem.asBytes(&optval))).link_next();
         (try ring.setsockopt(3, listen_fd, .socket, .reuseport, mem.asBytes(&optval))).link_next();
-        (try ring.bind(4, listen_fd, &addr.any, addr.getOsSockLen(), 0)).link_next();
-        _ = try ring.listen(5, listen_fd, 1, 0);
+        (try ring.bind(4, listen_fd, &addr.any, addr.getOsSockLen())).link_next();
+        _ = try ring.listen(5, listen_fd, 1);
         // Submit 4 operations
         try testing.expectEqual(4, try ring.submit());
         // Expect all to succeed