elf: return error.FlushFailure in flushObject and flushStaticLib codepaths when found errors

kubkon · kubkon · commit da417b851b8a · 2023-12-05T18:12:58.000+01:00
diff --git a/src/link/Elf.zig b/src/link/Elf.zig
@@ -1442,6 +1442,8 @@ pub fn flushStaticLib(self: *Elf, comp: *Compilation, module_obj_path: ?[]const
 
     try self.base.file.?.setEndPos(total_size);
     try self.base.file.?.pwriteAll(buffer.items, 0);
+
+    if (self.misc_errors.items.len > 0) return error.FlushFailure;
 }
 
 pub fn flushObject(self: *Elf, comp: *Compilation, module_obj_path: ?[]const u8) link.File.FlushError!void {
@@ -1512,6 +1514,8 @@ pub fn flushObject(self: *Elf, comp: *Compilation, module_obj_path: ?[]const u8)
     try self.writeSyntheticSectionsObject();
     try self.writeShdrTable();
     try self.writeElfHeader();
+
+    if (self.misc_errors.items.len > 0) return error.FlushFailure;
 }
 
 /// --verbose-link output

Original file line number	Diff line number	Diff line change
`@@ -1442,6 +1442,8 @@ pub fn flushStaticLib(self: Elf, comp: Compilation, module_obj_path: ?[]const`
`1442`	`1442`
`1443`	`1443`	`try self.base.file.?.setEndPos(total_size);`
`1444`	`1444`	`try self.base.file.?.pwriteAll(buffer.items, 0);`
	`1445`	`+`
	`1446`	`+ if (self.misc_errors.items.len > 0) return error.FlushFailure;`
`1445`	`1447`	`}`
`1446`	`1448`
`1447`	`1449`	`pub fn flushObject(self: Elf, comp: Compilation, module_obj_path: ?[]const u8) link.File.FlushError!void {`
`@@ -1512,6 +1514,8 @@ pub fn flushObject(self: Elf, comp: Compilation, module_obj_path: ?[]const u8)`
`1512`	`1514`	`try self.writeSyntheticSectionsObject();`
`1513`	`1515`	`try self.writeShdrTable();`
`1514`	`1516`	`try self.writeElfHeader();`
	`1517`	`+`
	`1518`	`+ if (self.misc_errors.items.len > 0) return error.FlushFailure;`
`1515`	`1519`	`}`
`1516`	`1520`
`1517`	`1521`	`/// --verbose-link output`