Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addTest and findProgram methods of std.Build use deprecated host field instead of graph.host #20035

Closed
Trevor-Strong opened this issue May 22, 2024 · 1 comment · Fixed by #20237

Comments

@Trevor-Strong
Copy link

Zig Version

0.12.0

Steps to Reproduce and Observed Behavior

In #19684 the host field was deprecated; however, the addTest and findProgam methods of std.Build still use this field instead of the suggested replacement of graph.host.

Expected Behavior

I would expect the standard library to use the graph.host field instead of the deprecated host field.

I have also checked that these are the only two places under std.Build or the build runner that make this mistake, and that this is present on master at the time of writing.

@Trevor-Strong Trevor-Strong added the bug Observed behavior contradicts documented or intended behavior label May 22, 2024
@Vexu Vexu added the zig build system std.Build, the build runner, `zig build` subcommand, package management label May 22, 2024
@Vexu Vexu added this to the 0.14.0 milestone May 22, 2024
@andrewrk andrewrk removed bug Observed behavior contradicts documented or intended behavior zig build system std.Build, the build runner, `zig build` subcommand, package management labels Jun 8, 2024
@andrewrk
Copy link
Member

andrewrk commented Jun 8, 2024

Unobservable internal implementation details are not a bug and do not warrant an issue.

Notice that your "observed behavior" contains no observed behavior.

@andrewrk andrewrk closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2024
@andrewrk andrewrk removed this from the 0.14.0 milestone Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants