Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig usage is not compliant with standard usage string #207

Closed
fsaintjacques opened this issue Oct 25, 2016 · 1 comment
Closed

zig usage is not compliant with standard usage string #207

fsaintjacques opened this issue Oct 25, 2016 · 1 comment
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase.
Milestone

Comments

@fsaintjacques
Copy link
Contributor

The following code mandates that --name and --export are provided. If they're required, they shouldn't be in the options section and be provided as arguments.

The solutions are:

  • move said options to required arguments, e.g. zip build <name> <export_type> <sources>...
  • provide default such that they can stay options (might be complicated with --name and multiple sources) and the user isn't forced to use them.

It creates initial churn when a new user types zig build my_file.zig.

@andrewrk
Copy link
Member

Good call.

For some context, name and export used to be specified in the source code in a "root export" node. It was removed in f1d3381.

In the future, I expect name and export type to be specified as part of the zig build system (see #204). So, for example, these values would be specified in build.zig and the actual command one would use in practice would be simply zig build.

However, the future is not yet here, and thus you are correct that we should make this change to reduce churn.

@andrewrk andrewrk added the enhancement Solving this issue will likely involve adding new logic or components to the codebase. label Oct 25, 2016
@andrewrk andrewrk modified the milestone: 0.1.0 Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase.
Projects
None yet
Development

No branches or pull requests

2 participants