Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate-c: remove concept of "translate mode" #2780

Closed
hryx opened this issue Jun 28, 2019 · 4 comments · Fixed by #3896
Closed

translate-c: remove concept of "translate mode" #2780

hryx opened this issue Jun 28, 2019 · 4 comments · Fixed by #3896
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. translate-c C to Zig source translation feature (@cImport)
Milestone

Comments

@hryx
Copy link
Contributor

hryx commented Jun 28, 2019

(Please feel free to add a more thorough description)

From conversations on IRC:

20:25 <hryx> what's the TLDR difference between include mode and -c mode?
20:26 <andrewrk> the idea was that in -c mode, you're translating a C project, so non-static functions should be `export` because that's what -c would do
20:26 <andrewrk> but in #include mode, it's like you just want to call the functions
20:26 <andrewrk> now that I'm thinking about it again though, I don't think there should be a difference
20:27 <andrewrk> because if you were to #include a non-static function in C, it would get exported. so the @cImport equivalent of that would be indeed, creating an export function and translating its definition
20:27 <andrewrk> so thinking about it again, I don't see why there needs to be 2 modes

This conversation resulted from work on #2569 .

@andrewrk andrewrk added this to the 0.6.0 milestone Jun 28, 2019
@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. translate-c C to Zig source translation feature (@cImport) labels Jun 28, 2019
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Oct 23, 2019
@FireFox317
Copy link
Contributor

This shouldn't be closed right? @Vexu reverted the change in his PR.

@Vexu
Copy link
Member

Vexu commented Dec 14, 2019

Only in stage 1, stage 2 no longer has translate mode.

@FireFox317
Copy link
Contributor

Ah, I see. Nice!

@andrewrk
Copy link
Member

It's fine to be closed because once self hosted translate-c is caught up, we can just delete the C++ implementation

@Vexu Vexu mentioned this issue Dec 22, 2019
16 tasks
@andrewrk andrewrk modified the milestones: 0.7.0, 0.6.0 Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. translate-c C to Zig source translation feature (@cImport)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants