Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: crossStorage backupMinio cmd parameters #419

Closed
MatanAmoyal1 opened this issue Sep 3, 2024 · 8 comments
Closed

[Feature]: crossStorage backupMinio cmd parameters #419

MatanAmoyal1 opened this issue Sep 3, 2024 · 8 comments

Comments

@MatanAmoyal1
Copy link
Contributor

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like.

Hi,
As the crossStorage option was added in the last release, I would like to request the addition of command-line parameters related to crossStorage Minio backup, similar to those already existing for Minio (such as MINIO_ACCESS_KEY, MINIO_SECRET_KEY, etc.).

https://github.com/zilliztech/milvus-backup/blob/main/core/paramtable/base_table.go#L411-L464

Describe an alternate solution.

No response

Anything else? (Additional Context)

example:
MINIO_BACKUP_ACCESS_KEY => minio.backupAccessKeyID
MINIO_BACKUP_SECRET_KEY => minio.backupSecretAccessKey
...

@oelezra
Copy link

oelezra commented Sep 3, 2024

Interesting

@gmoshiko-work
Copy link

we cant move it to production without this feature!

@wayblink
Copy link
Contributor

wayblink commented Sep 4, 2024

@MatanAmoyal1 @oelezra @gmoshiko-work Hi, glad to hear you are using this feature in production. This is a reasonable need. I think it is easy to support. I will appreciate it if you can make a contribution.

@MatanAmoyal1
Copy link
Contributor Author

@wayblink thanks for your answer. I open new PR, please review :)
#420

@wayblink
Copy link
Contributor

wayblink commented Sep 5, 2024

@MatanAmoyal1 Merged. Thanks for your PR.

@MatanAmoyal1
Copy link
Contributor Author

@wayblink Thanks!
What is the plan for the next release includes this change?

@wayblink
Copy link
Contributor

wayblink commented Sep 9, 2024

@MatanAmoyal1 Hi, v0.4.22 is released. https://github.com/zilliztech/milvus-backup/releases/tag/v0.4.22

@wayblink
Copy link
Contributor

close as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants