-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for React 16 (Fiber) #102
Comments
Got this issue with What's the way fwd? |
Have same issues with react 16.alpha |
Got the same issue with 15.6.1 works fine in dev but can't build. Using next.js "scripts": {
"dev": "next",
"build": "next build",
"start": "next start",
} |
Seems like my issue is related to #99 |
This issue has been open since June, but there isn't any recent activity on it. Has anyone proposed a path forward or come up with an alternative solution now that React 16 has been released? Thanks |
I've updated the plugin to version 3.0.0, to be compatible with React 16. I had to copy a big chunk of React internals to keep it working. This solution will probably not last for future versions. React is making it harder and harder to keep this plugin going. Please test the latest commit in your application and let me know the results so I can publish to npm. |
|
Works great @s0meone , thanks ;) |
@s0meone I'm still seeing an error regarding the EventPluginHub: |
Hi, |
Hey,
first of all thanks for the project. ;)
The current alpha of react 16 uses flat bundles (currently 16.0.0-alpha.13). Therefore there are no more react-dom/lib/* exports. There is a note in the fiber umbrella issue explicitly mentioning react-tap-event-plugin:
As far as i can see tap event plugin uses more exports from /lib than just EventPluginHub.
Namely:
React DOM currently exports:
What would be the path forwards? 🙈 Is there some way to help?
For reference heres the output of the webpack build:
The text was updated successfully, but these errors were encountered: