Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning if the number of saved requests exceeds a safe limit #349

Open
diego-aquino opened this issue Aug 24, 2024 · 0 comments
Open
Labels
feature New feature or request
Milestone

Comments

@diego-aquino
Copy link
Member

diego-aquino commented Aug 24, 2024

A memory leak will happen if users use saveRequests: true and forget to call interceptor.clear() regularly (i.e. afterEach). We could show a warning in the console if the number of saved intercepted requests exceeds a safe limit. The limit should be configurable per interceptor and default to all interceptors.

@diego-aquino diego-aquino converted this from a draft issue Aug 24, 2024
@diego-aquino diego-aquino added the feature New feature or request label Aug 24, 2024
@diego-aquino diego-aquino added this to the v0.10.0 milestone Aug 24, 2024
@diego-aquino diego-aquino self-assigned this Aug 24, 2024
@diego-aquino diego-aquino modified the milestones: v0.10.0, v0.11.0 Sep 3, 2024
@diego-aquino diego-aquino changed the title Show warning if the number of saved intercepted requests exceeds a customizable safe limit Show warning if the number of saved requests exceeds a safe limit Sep 8, 2024
@diego-aquino diego-aquino removed this from the v0.11.0 milestone Sep 8, 2024
@diego-aquino diego-aquino moved this from To do to Backlog in Zimic Sep 8, 2024
@diego-aquino diego-aquino removed their assignment Sep 8, 2024
@diego-aquino diego-aquino added this to the v0.18.0 milestone Sep 8, 2024
@diego-aquino diego-aquino moved this from Backlog to To do in Zimic Oct 10, 2024
@diego-aquino diego-aquino modified the milestones: v0.18.0, v0.12.0 Oct 10, 2024
@diego-aquino diego-aquino self-assigned this Oct 10, 2024
@diego-aquino diego-aquino removed their assignment Nov 1, 2024
@diego-aquino diego-aquino modified the milestones: v0.12.0, v0.13.0 Nov 15, 2024
@diego-aquino diego-aquino modified the milestones: v0.13.0, v0.14.0 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: To do
Development

No branches or pull requests

1 participant