Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize local interceptor start up time #376

Closed
diego-aquino opened this issue Aug 29, 2024 · 1 comment · Fixed by #377
Closed

Optimize local interceptor start up time #376

diego-aquino opened this issue Aug 29, 2024 · 1 comment · Fixed by #377
Assignees
@diego-aquino
Labels
performance Related to performance and benchmarks
Milestone
v0.9.2

Comments

@diego-aquino
Copy link
Member

diego-aquino commented Aug 29, 2024 •
edited
Loading

Starting the first local interceptor currently uses a dynamic import to get msw/node or msw/browser, depending on the environment. The dynamic import is not necessary and could be refactored to a normal import. This saves up ~40ms in the startup time on my machine.
@diego-aquino diego-aquino converted this from a draft issue Aug 29, 2024
@diego-aquino diego-aquino added the performance Related to performance and benchmarks label Aug 29, 2024
@diego-aquino diego-aquino self-assigned this Aug 29, 2024
@diego-aquino diego-aquino moved this from To do to In progress in Zimic Aug 29, 2024
@diego-aquino diego-aquino added this to the v0.9.2 milestone Aug 29, 2024
@diego-aquino diego-aquino mentioned this issue Aug 29, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Zimic Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Released in v0.9.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diego-aquino diego-aquino

Labels
performance Related to performance and benchmarks
Projects
Zimic
Status: Done
Milestone
v0.9.2
Development

Successfully merging a pull request may close this issue.

perf: local interceptor startup performance (#376) zimicjs/zimic
1 participant
@diego-aquino