Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse requests provided to onUnhandledRequest(request) callbacks #480

Closed
3 tasks done
diego-aquino opened this issue Nov 17, 2024 · 1 comment · Fixed by #482
Closed
3 tasks done

Parse requests provided to onUnhandledRequest(request) callbacks #480

diego-aquino opened this issue Nov 17, 2024 · 1 comment · Fixed by #482
Assignees
Labels
feature New feature or request
Milestone

Comments

@diego-aquino
Copy link
Member

Prerequisites

  • I confirm that none of the open issues match my proposal
  • I confirm that my proposal is not yet available in the latest version of Zimic (see the documentation and the releases)

Scope

Improves an existing behavior

Compatibility

  • This is a breaking change

Context

When working with requests in interceptors, we parse them by default to provide a better developer experience, providing the original fetch Request in request.raw. However, only the raw requests are provided to onUnhandledRequest(request) callbacks, causing an inconsistency.

Feature description

We should provide a parsed request to onUnhandledRequest(request), similar to how they are used in interceptors.

@diego-aquino diego-aquino added feature New feature or request needs triage labels Nov 17, 2024
@diego-aquino diego-aquino self-assigned this Nov 17, 2024
@diego-aquino diego-aquino moved this to To do in Zimic Nov 17, 2024
@diego-aquino diego-aquino added this to the v0.10.0 milestone Nov 17, 2024
@diego-aquino diego-aquino moved this from To do to In progress in Zimic Nov 17, 2024
@diego-aquino diego-aquino moved this from In progress to In review in Zimic Nov 17, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Zimic Nov 17, 2024
Copy link
Contributor

Released in v0.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant