Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code in swipe recognizer #103

Open
c-smile opened this issue Oct 30, 2022 · 1 comment
Open

Dead code in swipe recognizer #103

c-smile opened this issue Oct 30, 2022 · 1 comment
Assignees
Labels

Comments

@c-smile
Copy link

c-smile commented Oct 30, 2022

I believe this

if (velocity < this.escapeVelocity) {

should be

for (var i = 0; i < output.data.length; i++) {
        if (output.data[i].velocity < this.escapeVelocity) {
          return null;
        }
      }

otherwise, it is useless.

@lasabahebwa
Copy link
Collaborator

@c-smile This was rectified in the codebase and the changes were pushed. Thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants