Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring tslint to fail on warnings #27

Closed
pelotom opened this issue Sep 9, 2017 · 1 comment · Fixed by #32
Closed

Allow configuring tslint to fail on warnings #27

pelotom opened this issue Sep 9, 2017 · 1 comment · Fixed by #32

Comments

@pelotom
Copy link

pelotom commented Sep 9, 2017

Hi, this is a great plugin, thanks for making it! I've replaced tslint-loader with it because it's much faster. However, one thing I'm missing from that loader is the failOnHint option, which will fail the build if any lint warnings occur. I want to turn this on specifically when building in CI, but not when developing locally.
@pelotom pelotom changed the title Allow configuring tslint to fail on error Allow configuring tslint to fail on warnings Sep 9, 2017
@zinserjan
Copy link
Owner

Yep, the option makes sense.

@zinserjan zinserjan mentioned this issue Sep 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tslint emit failures as errors zinserjan/ts-checker-webpack-plugin
2 participants
@pelotom @zinserjan